[core] Use lazy quantifier in regex for sanitizing dates in js_to_json #8295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the following JavaScript code as string:
The greedy quantifier's usage matches the string till the last quote instead of just the text inside the parenthesis. This patch fixes that using the
STRING_RE
regex for proper string literal matching.Also updated tests.
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
🤖 Generated by Copilot at c3dadad
Summary
🐛🕒🎬
Fix
js_to_json
bug with single-quoted strings innew Date
arguments. This improves YouTube metadata extraction.Walkthrough
js_to_json
function that caused parsing errors for single-quoted strings innew Date
constructor (link)