Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/thisav] Remove #8346

Merged
merged 1 commit into from Nov 11, 2023
Merged

[ie/thisav] Remove #8346

merged 1 commit into from Nov 11, 2023

Conversation

bashonly
Copy link
Member

@bashonly bashonly commented Oct 14, 2023

Site should not be supported

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

🤖 Generated by Copilot at 6b5320c

Summary

🗑️🏴‍☠️🧪

Remove support for thisav.com as a piracy site. Delete the ThisAVIE extractor and add thisav.com to the list of known piracy sites in unsupported.py.

To avoid any legal mishaps
We removed the ThisAVIE class
The site thisav.com
Is now blocked by our program
And we added a test case to pass

Walkthrough

  • Remove ThisAVIE extractor as thisav.com is now a known piracy site (link, link)
  • Add thisav.com to the list of known piracy sites in KnownPiracyIE extractor (link)
  • Add test case for KnownPiracyIE extractor using thisav.com URL (link)

@bashonly bashonly added the docs/meta/cleanup related to docs, code cleanup, templates, devscripts etc label Oct 14, 2023
@bashonly bashonly self-assigned this Nov 7, 2023
)

_TESTS = [{
'url': 'http://dood.to/e/5s1wmbdacezb',
'only_matching': True,
}, {
'url': 'https://thisav.com/en/terms',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested this url, but why don't we actually just use /favicon.ico for all the piracy sites (eg https://thisav.com/favicon.ico)? That url exists for every website, and stores just the site's logo (which I highly doubt would be copyright, and it's not really our problem if it is)

@bashonly bashonly merged commit cb480e3 into yt-dlp:master Nov 11, 2023
17 checks passed
@bashonly bashonly deleted the cleanup/thisav branch December 7, 2023 15:09
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs/meta/cleanup related to docs, code cleanup, templates, devscripts etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants