New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNBCVideo error #8378
Labels
site-bug
Issue with a specific website
Comments
jacobrosenfeld
added
site-bug
Issue with a specific website
triage
Untriaged issue
labels
Oct 18, 2023
Related: #5871 But this seems like a different issue |
My group and I are in a Software Engineering class in college. We will implement an extractor specifically for CNBC to tackle this issue. |
9 tasks
gonzalezjo
pushed a commit
to gonzalezjo/yt-dlp
that referenced
this issue
Dec 10, 2023
Fixes yt-dlp#8378 by rewriting the CNBC video extractor. - Removes `CNBCIE`, which is an extractor for a CNBC video platform that no longer exists. - Updates CNBCVideoIE - Adds tests - Supports author, channel, formats, ID (of course), upload date, URL (of course), title (of course), description, duration, timestamp, and thumbnails. Squashed commit of the following: commit c4c6a3e Author: J. Gonzalez <gonzalezjo@users.noreply.github.comm> Date: Sat Dec 9 20:12:51 2023 -0500 Final cleanups commit 98837e5 Author: J. Gonzalez <gonzalezjo@users.noreply.github.comm> Date: Sat Dec 9 20:06:01 2023 -0500 Rebase 'Further cleanups + better extraction' Cool. commit 210a0e5 Author: zhijinwuu <zhijinw@andrew.cmu.edu> Date: Sat Dec 9 19:48:58 2023 -0500 new tests commit 91fcdfb Author: zhijinwuu <zhijinw@andrew.cmu.edu> Date: Sat Dec 9 19:41:45 2023 -0500 added a test commit 28a0100 Author: ruiminggu <ruimingg@andrew.cmu.edu> Date: Sat Dec 9 19:11:34 2023 -0500 fixed test commit 37c4b72 Author: ruiminggu <ruimingg@andrew.cmu.edu> Date: Sat Dec 9 19:11:17 2023 -0500 fixed test commit 6f42a60 Author: J. Gonzalez <gonzalezjo@users.noreply.github.comm> Date: Sat Dec 9 18:47:17 2023 -0500 Remove CNBCIE Seems to not exist anymore. commit d9dd742 Author: J. Gonzalez <gonzalezjo@users.noreply.github.comm> Date: Sat Dec 9 18:44:11 2023 -0500 Code cleanups commit 72e9d82 Merge: b272679 b5260a1 Author: J. Gonzalez <gonzalezjo@users.noreply.github.comm> Date: Sat Dec 9 18:36:30 2023 -0500 Merge branch 'rachel-cnbc' into cnbc commit b272679 Merge: 1823eb9 188191a Author: J. Gonzalez <gonzalezjo@users.noreply.github.comm> Date: Sat Dec 9 18:35:33 2023 -0500 Merge branch 'noor-cnbc' into cnbc commit 188191a Author: J. Gonzalez <gonzalezjo@users.noreply.github.comm> Date: Sat Dec 9 18:34:11 2023 -0500 Simplify noor-code commit 7c43a9d Author: J. Gonzalez <gonzalezjo@users.noreply.github.comm> Date: Sat Dec 9 17:37:00 2023 -0500 Mostly fix tests Nice. commit db204a5 Author: Noor Mostafa <noormostafa@noors-air-3.wifi.local.cmu.edu> Date: Sat Dec 9 17:18:57 2023 -0500 test case for CNBC video commit b5260a1 Author: zhijinwuu <zhijinw@andrew.cmu.edu> Date: Sat Dec 9 17:17:04 2023 -0500 format upload_date commit 1823eb9 Author: ruiminggu <ruimingg@andrew.cmu.edu> Date: Sat Dec 9 15:55:04 2023 -0500 modify for properly capitalize the channel commit c164f09 Author: zhijinwuu <zhijinw@andrew.cmu.edu> Date: Sat Dec 9 15:38:40 2023 -0500 add the case where author is NA commit 3bee446 Author: zhijinwuu <zhijinw@andrew.cmu.edu> Date: Sat Dec 9 15:26:03 2023 -0500 upload_date, video_status, author commit 668503b Author: zhijinwuu <zhijinw@andrew.cmu.edu> Date: Sat Dec 9 15:25:08 2023 -0500 original commit fb8f173 Author: zhijinwuu <zhijinw@andrew.cmu.edu> Date: Sat Dec 9 15:09:44 2023 -0500 upload_date, video_status, and author commit b57090b Author: Noor Mostafa <noormostafa@noors-air-3.wifi.local.cmu.edu> Date: Fri Dec 8 16:24:36 2023 -0500 metadata using builtin functions commit a3b0068 Author: ruiminggu <ruimingg@andrew.cmu.edu> Date: Fri Dec 8 14:59:57 2023 -0500 channel and duration commit 09ccfd7 Author: Noor Mostafa <noormostafa@noors-air-3.wifi.local.cmu.edu> Date: Thu Dec 7 17:16:17 2023 -0500 Added metadata for thumbnail, timestamp, and description commit fcb554e Author: Noor Mostafa <noormostafa@noors-air-3.wifi.local.cmu.edu> Date: Thu Dec 7 14:51:10 2023 -0500 thumbnail metadata commit 2101192 Author: J. Gonzalez <gonzalezjo@users.noreply.github.comm> Date: Thu Dec 7 12:45:36 2023 -0500 Basic video extraction supported for CNBC. Does the absolute barest minimum.
seproDev
added a commit
that referenced
this issue
Feb 23, 2024
Closes #5871, Closes #8378 Authored by: gonzalezjo, Noor-5, zhijinwuu, ruiminggu, seproDev Co-authored-by: Noor Mostafa <93787875+Noor-5@users.noreply.github.com> Co-authored-by: zhijinwuu <zhijinw@andrew.cmu.edu> Co-authored-by: ruiminggu <ruimingg@andrew.cmu.edu> Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this issue
Apr 21, 2024
Closes yt-dlp#5871, Closes yt-dlp#8378 Authored by: gonzalezjo, Noor-5, zhijinwuu, ruiminggu, seproDev Co-authored-by: Noor Mostafa <93787875+Noor-5@users.noreply.github.com> Co-authored-by: zhijinwuu <zhijinw@andrew.cmu.edu> Co-authored-by: ruiminggu <ruimingg@andrew.cmu.edu> Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE
Checklist
Region
USA
Provide a description that is worded well enough to be understood
CNBCVideo not working
Provide verbose output that clearly demonstrates the problem
yt-dlp -vU <your command line>
)'verbose': True
toYoutubeDL
params instead[debug] Command-line config
) and insert it belowComplete Verbose Output
The text was updated successfully, but these errors were encountered: