[ie/twitcasting] twitcasting live element status had change from 'onl… #8427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ine' to 'recorded'.
11 tasks
11 tasks
bashonly
approved these changes
Oct 25, 2023
JC-Chung
reviewed
Oct 27, 2023
bashonly
added
pending-fixes
bashonly
added
pending-review
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Closes yt-dlp#8431 Authored by: JC-Chung, saintliao Co-authored-by: JC-Chung <52159296+JC-Chung@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
As the website has been changed the 'is live' element name from 'online' to 'recorded' on twitcasting, the extractor was broken and could not download live stream now.
Closes #8431
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
🤖 Generated by Copilot at c3ad151
Summary
🐛🎥🔓
Fix
is_livedetection for Twitcasting videos. Usedata-status="recorded"instead ofdata-status="online"inyt_dlp/extractor/twitcasting.py.Walkthrough
data-status="recorded"instead ofdata-status="online"in the webpage (link)