Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/orf] Add extractor for sound.orf.at podcasts #8486

Merged
merged 5 commits into from Nov 11, 2023

Conversation

Esokrates
Copy link
Contributor

@Esokrates Esokrates commented Oct 31, 2023

Add orf extractor for podcasts

This adds support for downloading podcasts from https://sound.orf.at/podcast/sender.

Partly Fixes #5265

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

馃 Generated by Copilot at e50d532

Summary

馃帣锔忦焽︷焽光灂

Add a new extractor class ORFPodcastIE for ORF podcasts in the orf.py module and register it in the _extractors.py module. This allows yt-dlp to download audio programs from the Austrian public broadcaster.

New ORFPodcastIE
Extracts audio from ORF
Listen in winter

Walkthrough

  • Add support for ORF podcasts with a new extractor class (link, link)
    • Define the ORFPodcastIE class in orf.py that inherits from InfoExtractor (link)
    • Implement the _VALID_URL pattern to match the ORF podcast URLs (link)
    • Implement the _TESTS list to provide an example URL and expected metadata (link)
    • Implement the _real_extract method to download the JSON data from the ORF API and extract the audio URL, title, description, duration, and series name (link)
    • Use the clean_html helper function to remove HTML tags from the description (link)
    • Register the new extractor class in the _extractors.py module (link)

yt_dlp/extractor/orf.py Outdated Show resolved Hide resolved
yt_dlp/extractor/orf.py Outdated Show resolved Hide resolved
@bashonly bashonly added site-request Request to support a new website pending-fixes PR has had changes requested labels Oct 31, 2023
yt_dlp/extractor/orf.py Outdated Show resolved Hide resolved
yt_dlp/extractor/orf.py Show resolved Hide resolved
Copy link
Member

@bashonly bashonly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yt_dlp/extractor/orf.py Outdated Show resolved Hide resolved
@bashonly bashonly added pending-review PR needs a review and removed pending-fixes PR has had changes requested labels Nov 1, 2023
@bashonly bashonly self-assigned this Nov 5, 2023
@bashonly bashonly removed the pending-review PR needs a review label Nov 5, 2023
@bashonly bashonly merged commit 6ba3085 into yt-dlp:master Nov 11, 2023
16 checks passed
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-request Request to support a new website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[orf:radio] add support for sound.orf.at
3 participants