-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ie/orf] Add extractor for sound.orf.at podcasts #8486
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seproDev
reviewed
Oct 31, 2023
bashonly
requested changes
Nov 1, 2023
bashonly
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
seproDev
approved these changes
Nov 2, 2023
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Closes yt-dlp#5265 Authored by: Esokrates
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
Jun 1, 2024
* maintain support for xx.orf.at/player/... URLs * add `ORFRadioCollectionIE` to support playlists in ORF Sound * back-port and re-work `ORFPodcastIE` from yt-dlp/yt-dlp#8486, thx Esokrates
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
Jun 1, 2024
* maintain support for xx.orf.at/player/... URLs * add `ORFRadioCollectionIE` to support playlists in ORF Sound * back-port and re-work `ORFPodcastIE` from yt-dlp/yt-dlp#8486, thx Esokrates
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
Jun 11, 2024
* maintain support for xx.orf.at/player/... URLs * add `ORFRadioCollectionIE` to support playlists in ORF Sound * back-port and re-work `ORFPodcastIE` from yt-dlp/yt-dlp#8486, thx Esokrates
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
Jun 11, 2024
* maintain support for xx.orf.at/player/... URLs * add `ORFRadioCollectionIE` to support playlists in ORF Sound * back-port and re-work `ORFPodcastIE` from yt-dlp/yt-dlp#8486, thx Esokrates
dirkf
added a commit
to ytdl-org/youtube-dl
that referenced
this pull request
Jun 11, 2024
* maintain support for xx.orf.at/player/... URLs * add `ORFRadioCollectionIE` to support playlists in ORF Sound * back-port and re-work `ORFPodcastIE` from yt-dlp/yt-dlp#8486, thx Esokrates
github-actions bot
added a commit
to hellopony/youtube-dl
that referenced
this pull request
Jun 11, 2024
* https://github.com/ytdl-org/youtube-dl: [VidLii] Add 720p support (ytdl-org#30924) [ORF] Skip tests with limited availability [ORF] Re-factor and update`ORFFM4StoryIE` * fix getting media via DASH instead of inaccessible mp4 * also get in-page YT media [ORF] Support sound.orf.at, updating `ORFRadioIE` * maintain support for xx.orf.at/player/... URLs * add `ORFRadioCollectionIE` to support playlists in ORF Sound * back-port and re-work `ORFPodcastIE` from yt-dlp/yt-dlp#8486, thx Esokrates [ORF] Support on.orf.at, replacing `ORFTVthekIE` * add `ORFONIE`, back-porting yt-dlp PR yt-dlp/yt-dlp#9113 and friends: thx HobbyistDev, TuxCoder, seproDev * re-factor to support livestreams via new `ORFONliveIE` [test] Improve download test * skip reason can't be unicode in Py2 * remove duplicate assert...Equal functions [core] Re-factor with `_fill_common_fields()` as used in yt-dlp [core] Safer handling of nested playlist data [mixcloud] updated mixcloud API server address (ytdl-org#32557)
dirkf
added a commit
to ytdl-org/ytdl-nightly
that referenced
this pull request
Jun 12, 2024
* maintain support for xx.orf.at/player/... URLs * add `ORFRadioCollectionIE` to support playlists in ORF Sound * back-port and re-work `ORFPodcastIE` from yt-dlp/yt-dlp#8486, thx Esokrates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add orf extractor for podcasts
This adds support for downloading podcasts from
https://sound.orf.at/podcast/sender
.Partly Fixes #5265
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
馃 Generated by Copilot at e50d532
Summary
馃帣锔忦焽︷焽光灂
Add a new extractor class
ORFPodcastIE
for ORF podcasts in theorf.py
module and register it in the_extractors.py
module. This allows yt-dlp to download audio programs from the Austrian public broadcaster.Walkthrough
ORFPodcastIE
class inorf.py
that inherits fromInfoExtractor
(link)_VALID_URL
pattern to match the ORF podcast URLs (link)_TESTS
list to provide an example URL and expected metadata (link)_real_extract
method to download the JSON data from the ORF API and extract the audio URL, title, description, duration, and series name (link)clean_html
helper function to remove HTML tags from the description (link)_extractors.py
module (link)