[utils] traverse_obj: Move is_user_input into output template
#8673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grub4K
added
the
docs/meta/cleanup
|
We should try and do It might make sense to instead have that be done when we know what we need for outtmpl, but it would be nice if we could separate concerns and not have a single, massive traversal + outtmpl PR |
We'll be able to split it up after we have the full picture. |
Grub4K
commented
Nov 28, 2023
|
Raise a deprecation_warning if is_user_input is being used. We can remove the param completely after a while. |
|
I don't think that should be needed. We are explicitly stating that it is private API only. |
|
Even so, no harm in leaving it for a bit just in case. |
pukkandan
approved these changes
Dec 6, 2023
bashonly
approved these changes
Dec 6, 2023
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
…-dlp#8673) Authored by: Grub4K
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
Apr 27, 2024
* remove `is_user_input` option per yt-dlp/yt-dlp#8673 * support traversal of compat_xml_etree_ElementTree_Element per yt-dlp/yt-dlp#8911 * allow un/branching using all and any per yt-dlp/yt-dlp#9571 * support traversal of compat_cookies.Morsel and multiple types in `set()` keys per yt-dlp/yt-dlp#9577 thx Grub4k for these * also, move traversal tests to a separate class
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
Apr 27, 2024
* remove `is_user_input` option per yt-dlp/yt-dlp#8673 * support traversal of compat_xml_etree_ElementTree_Element per yt-dlp/yt-dlp#8911 * allow un/branching using all and any per yt-dlp/yt-dlp#9571 * support traversal of compat_cookies.Morsel and multiple types in `set()` keys per yt-dlp/yt-dlp#9577 thx Grub4k for these * also, move traversal tests to a separate class
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
Apr 27, 2024
* remove `is_user_input` option per yt-dlp/yt-dlp#8673 * support traversal of compat_xml_etree_ElementTree_Element per yt-dlp/yt-dlp#8911 * allow un/branching using all and any per yt-dlp/yt-dlp#9571 * support traversal of compat_cookies.Morsel and multiple types in `set()` keys per yt-dlp/yt-dlp#9577 thx Grub4k for these * also, move traversal tests to a separate class
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
Apr 27, 2024
* remove `is_user_input` option per yt-dlp/yt-dlp#8673 * support traversal of compat_xml_etree_ElementTree_Element per yt-dlp/yt-dlp#8911 * allow un/branching using all and any per yt-dlp/yt-dlp#9571 * support traversal of compat_cookies.Morsel and multiple types in `set()` keys per yt-dlp/yt-dlp#9577 thx Grub4k for these * also, move traversal tests to a separate class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Preparations for
traverse_objrewrite in combination with output template adjustments.Both private parameters should be moved out of the function and into
outtmplinstead.Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?