Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[utils] traverse_obj: Convenience improvements #9577

Merged
merged 5 commits into from Apr 1, 2024

Conversation

Grub4K
Copy link
Member

@Grub4K Grub4K commented Mar 31, 2024

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Adds support for:

  • http.cookies.Morsel
  • Multi type filters ({type, type})
  • Update docs with changes
Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense

What is the purpose of your pull request?

  • Core bug fix/improvement

@Grub4K
Copy link
Member Author

Grub4K commented Mar 31, 2024

Side note for future PR: A full paragraph on how to use traverse_obj in CONTRIBUTING.md could potentially be helpful

@pukkandan
Copy link
Member

  • Multi type filters ({(type, type)})

Should it be {type, type}?

@Grub4K
Copy link
Member Author

Grub4K commented Mar 31, 2024

Should it be {type, type}?

Done

@Grub4K Grub4K merged commit 32abfb0 into yt-dlp:master Apr 1, 2024
15 checks passed
@Grub4K Grub4K deleted the feat/traversal-stuff branch April 1, 2024 00:12
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Add support for:
- `http.cookies.Morsel`
- Multi type filters (`{type, type}`)

Authored by: Grub4K
dirkf added a commit to dirkf/youtube-dl that referenced this pull request Apr 27, 2024
* remove `is_user_input` option per yt-dlp/yt-dlp#8673
* support traversal of compat_xml_etree_ElementTree_Element per yt-dlp/yt-dlp#8911
* allow un/branching using all and any per yt-dlp/yt-dlp#9571
* support traversal of compat_cookies.Morsel and multiple types in `set()` keys per yt-dlp/yt-dlp#9577
thx Grub4k for these
* also, move traversal tests to a separate class
dirkf added a commit to dirkf/youtube-dl that referenced this pull request Apr 27, 2024
* remove `is_user_input` option per yt-dlp/yt-dlp#8673
* support traversal of compat_xml_etree_ElementTree_Element per yt-dlp/yt-dlp#8911
* allow un/branching using all and any per yt-dlp/yt-dlp#9571
* support traversal of compat_cookies.Morsel and multiple types in `set()` keys per yt-dlp/yt-dlp#9577
thx Grub4k for these
* also, move traversal tests to a separate class
dirkf added a commit to dirkf/youtube-dl that referenced this pull request Apr 27, 2024
* remove `is_user_input` option per yt-dlp/yt-dlp#8673
* support traversal of compat_xml_etree_ElementTree_Element per yt-dlp/yt-dlp#8911
* allow un/branching using all and any per yt-dlp/yt-dlp#9571
* support traversal of compat_cookies.Morsel and multiple types in `set()` keys per yt-dlp/yt-dlp#9577
thx Grub4k for these
* also, move traversal tests to a separate class
dirkf added a commit to dirkf/youtube-dl that referenced this pull request Apr 27, 2024
* remove `is_user_input` option per yt-dlp/yt-dlp#8673
* support traversal of compat_xml_etree_ElementTree_Element per yt-dlp/yt-dlp#8911
* allow un/branching using all and any per yt-dlp/yt-dlp#9571
* support traversal of compat_cookies.Morsel and multiple types in `set()` keys per yt-dlp/yt-dlp#9577
thx Grub4k for these
* also, move traversal tests to a separate class
dirkf added a commit to dirkf/youtube-dl that referenced this pull request Apr 27, 2024
* remove `is_user_input` option per yt-dlp/yt-dlp#8673
* support traversal of compat_xml_etree_ElementTree_Element per yt-dlp/yt-dlp#8911
* allow un/branching using all and any per yt-dlp/yt-dlp#9571
* support traversal of compat_cookies.Morsel and multiple types in `set()` keys per yt-dlp/yt-dlp#9577
thx Grub4k for these
* also, move traversal tests to a separate class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants