Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/Facebook] Fix Unhandled IndexError #8681

Merged
merged 14 commits into from Dec 24, 2023
Merged

Conversation

kclauhk
Copy link
Contributor

@kclauhk kclauhk commented Nov 29, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

ADD DESCRIPTION HERE

Fixes #8669

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@seproDev seproDev added the site-bug Issue with a specific website label Nov 29, 2023
Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
@bashonly bashonly self-requested a review December 6, 2023 18:49
Copy link
Collaborator

@seproDev seproDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also please add a test case for a video linked to from a memory?

yt_dlp/extractor/facebook.py Outdated Show resolved Hide resolved
yt_dlp/extractor/facebook.py Outdated Show resolved Hide resolved
@seproDev seproDev added the pending-fixes PR has had changes requested label Dec 21, 2023
kclauhk and others added 4 commits December 23, 2023 00:31
Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
@seproDev seproDev added pending-review PR needs a review and removed pending-fixes PR has had changes requested labels Dec 22, 2023
Copy link
Member

@bashonly bashonly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note for maintainers: consider that the scope of this PR has expanded beyond just handling the indexerror when writing the commit msg

yt_dlp/extractor/facebook.py Outdated Show resolved Hide resolved
@bashonly bashonly removed the pending-review PR needs a review label Dec 24, 2023
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
@seproDev seproDev merged commit c39358a into yt-dlp:master Dec 24, 2023
6 checks passed
@kclauhk kclauhk deleted the issue_8669 branch December 27, 2023 14:23
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
- Support group /posts/ URLs
- Raise a proper error message if no formats are found

Closes yt-dlp#8669
Authored by: kclauhk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled IndexError when downloading video from Facebook
4 participants