Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ie/Facebook] Fix Unhandled IndexError #8681

Merged
merged 14 commits into from
Dec 24, 2023
Merged

[ie/Facebook] Fix Unhandled IndexError #8681

Changes from 5 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
1825393
Update facebook.py
kclauhk Nov 29, 2023
3abeecf
Update facebook.py
kclauhk Nov 29, 2023
cdad3d2
Update facebook.py
kclauhk Nov 30, 2023
5603670
Update facebook.py
kclauhk Nov 30, 2023
199342b
Update yt_dlp/extractor/facebook.py
pukkandan Nov 30, 2023
01be29d
Update yt_dlp/extractor/facebook.py
kclauhk Nov 30, 2023
d0b715b
Update yt_dlp/extractor/facebook.py
kclauhk Dec 22, 2023
92c3266
Update yt_dlp/extractor/facebook.py
kclauhk Dec 22, 2023
771026f
Update facebook.py
kclauhk Dec 22, 2023
7023741
Update facebook.py
kclauhk Dec 22, 2023
d3b793a
Update yt_dlp/extractor/facebook.py
seproDev Dec 22, 2023
6bc4e1e
Update extractor for new URL #3824
kclauhk Dec 23, 2023
7ec3928
Revert "Update extractor for new URL #3824"
seproDev Dec 24, 2023
12d83ee
Update yt_dlp/extractor/facebook.py
kclauhk Dec 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 5 additions & 4 deletions yt_dlp/extractor/facebook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ class FacebookIE(InfoExtractor):
)\?(?:.*?)(?:v|video_id|story_fbid)=|
[^/]+/videos/(?:[^/]+/)?|
[^/]+/posts/|
groups/[^/]+/permalink/|
groups/[^/]+/(?:permalink|posts)/|
watchparty/
)|
facebook:
Expand Down Expand Up @@ -612,9 +612,10 @@ def parse_attachment(attachment, key='media'):
nodes = variadic(traverse_obj(data, 'nodes', 'node') or [])
attachments = traverse_obj(nodes, (
..., 'comet_sections', 'content', 'story', (None, 'attached_story'), 'attachments',
..., ('styles', 'style_type_renderer'), 'attachment'), expected_type=dict) or []
..., ('styles', 'throwbackStyles', 'style_type_renderer'), (None, ...), 'attachment'), expected_type=dict) or []
kclauhk marked this conversation as resolved.
Show resolved Hide resolved
for attachment in attachments:
ns = try_get(attachment, lambda x: x['all_subattachments']['nodes'], list) or []
ns = (try_get(attachment, lambda x: x['all_subattachments']['nodes'], list)
or traverse_obj(attachment, (..., 'attachments', ..., 'styles', 'attachment'), expected_type=dict) or [])
kclauhk marked this conversation as resolved.
Show resolved Hide resolved
for n in ns:
parse_attachment(n)
parse_attachment(attachment)
Expand All @@ -637,7 +638,7 @@ def parse_attachment(attachment, key='media'):
if len(entries) > 1:
return self.playlist_result(entries, video_id)

video_info = entries[0]
video_info = entries[0] if entries else {'id': video_id}
webpage_info = extract_metadata(webpage)
# honor precise duration in video info
if video_info.get('duration'):
Expand Down