feat(ADN): Add German variant and season downloads #8708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pukkandan
reviewed
Dec 3, 2023
yt_dlp/extractor/adn.py
Outdated
Comment on lines
53
to
60
| 'url': 'https://animationdigitalnetwork.de/video/tokyo-mew-mew-new/19818-folge-1', | ||
| 'info_dict': { | ||
| 'id': '19818', | ||
| 'ext': 'mp4', | ||
| 'episode_number': 1, | ||
| 'duration': 1429, | ||
| }, | ||
| 'skip': 'Only available in region (FR, ...)', |
There was a problem hiding this comment.
Try running the test locally after commenting out skip
There was a problem hiding this comment.
Currently the test fails even when running it from Germany. The German site is still under contrsuction and some stream variants (namely mobile and sd quality) are not yet available. This leads to a runtime error. I'll try again from time to time and adjust the test accordingly.
test is not yet working due to the German site still being under construction
|
The German site is still under contrsuction and some stream variants (namely mobile and sd quality) are not yet available. Will keep this as a draft until the German site is working. |
infanf
changed the title
pukkandan
reviewed
Dec 5, 2023
extractor args not needed add base class
|
German site is still in beta, but it works now (at least for some episodes). This means I was able to successfully run the tests locally. |
10 tasks
seproDev
requested changes
Jan 15, 2024
use f-strings add headers to all requests move language to url regex resolves yt-dlp#8945 resolves yt-dlp#6643
seproDev
approved these changes
Jan 15, 2024
seproDev
added
pending-review
bashonly
approved these changes
Jan 19, 2024
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
- Add extractor for seasons Closes yt-dlp#6643, Closes yt-dlp#8945 Authored by: infanf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Add support for the newly launched German site. The German site is accessible from DE, AT, CH, LI, LU under animationdigitalnetwork.de (instead of .fr). Backend API is the same as on the French site.
German site provides German subtitles and dubs (currently none available).
And while I'm at it, might as well add season download support as requested in #6643
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?