Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add domain animationdigitalnetwork.de to supported site ADN #8945

Closed
10 tasks done
Killua-Zolldyck opened this issue Jan 7, 2024 · 2 comments
Closed
10 tasks done
Labels
patch-available There is patch available that should fix this issue. Someone needs to make a PR with it site-enhancement Feature request for some website

Comments

@Killua-Zolldyck
Copy link

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

  • I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

Region

Germany

Example URLs

https://animationdigitalnetwork.de/video/pon-no-michi/24022-folge-1-jouons-au-mah-jong

Provide a description that is worded well enough to be understood

The French provider ADN added a portal for Germany a few weeks ago. Downloading from ADN in France using the domain animationdigitalnetwork.fr works fine, but trying to download using the German domain animationdigitalnetwork.de is switching to "generic" instead of "ADN". Unfortunately the German subs are available only while using the German domain.

I guess this could be easily fixed with just adding the domain animationdigitalnetwork.de to the provider ADN so yt-dlp is switching over to ADN and not to generic.

Provide verbose output that clearly demonstrates the problem

  • Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
  • If using API, add 'verbose': True to YoutubeDL params instead
  • Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output

[debug] Extracting cookies from: "C:\Users\Heiko\AppData\Roaming\Mozilla\Firefox\Profiles\v9vnouv9.default-release\cookies.sqlite"
Extracted 325 cookies from firefox
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version nightly@2024.01.05.232702 from yt-dlp/yt-dlp-nightly-builds [b6951271a] (win_exe)
[debug] Python 3.8.10 (CPython AMD64 64bit) - Windows-10-10.0.22631-SP0 (OpenSSL 1.1.1k  25 Mar 2021)
[debug] exe versions: ffmpeg N-113146-g56c5930ec3 (fdk,setts), ffprobe N-113146-g56c5930ec3
[debug] Optional libraries: Cryptodome-3.19.1, brotli-1.1.0, certifi-2023.11.17, mutagen-1.47.0, requests-2.31.0, sqlite3-3.35.5, urllib3-2.1.0, websockets-12.0
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests, websockets
[debug] Loaded 1798 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp-nightly-builds/releases/latest
Latest version: nightly@2024.01.05.232702 from yt-dlp/yt-dlp-nightly-builds
yt-dlp is up to date (nightly@2024.01.05.232702 from yt-dlp/yt-dlp-nightly-builds)
[generic] Extracting URL: https://animationdigitalnetwork.de/video/pon-no-michi/24022-folge-1-jouons-au-mah-jong
[generic] 24022-folge-1-jouons-au-mah-jong: Downloading webpage
WARNING: [generic] Falling back on generic information extractor
[generic] 24022-folge-1-jouons-au-mah-jong: Extracting information
[debug] Looking for embeds
ERROR: Unsupported URL: https://animationdigitalnetwork.de/video/pon-no-michi/24022-folge-1-jouons-au-mah-jong
Traceback (most recent call last):
  File "yt_dlp\YoutubeDL.py", line 1587, in wrapper
  File "yt_dlp\YoutubeDL.py", line 1722, in __extract_info
  File "yt_dlp\extractor\common.py", line 718, in extract
  File "yt_dlp\extractor\generic.py", line 2531, in _real_extract
yt_dlp.utils.UnsupportedError: Unsupported URL: https://animationdigitalnetwork.de/video/pon-no-michi/24022-folge-1-jouons-au-mah-jong
@Killua-Zolldyck Killua-Zolldyck added site-enhancement Feature request for some website triage Untriaged issue labels Jan 7, 2024
@Killua-Zolldyck Killua-Zolldyck changed the title Please add domain animationdigitalnetwork,de to supported site ADN Please add domain animationdigitalnetwork.de to supported site ADN Jan 7, 2024
@Killua-Zolldyck
Copy link
Author

Killua-Zolldyck commented Jan 9, 2024

I've fixed the adn,py myself. I've attached the updated file as txt.

adn.txt

@bashonly bashonly added patch-available There is patch available that should fix this issue. Someone needs to make a PR with it and removed triage Untriaged issue labels Jan 9, 2024
@infanf
Copy link
Contributor

infanf commented Jan 10, 2024

@Killua-Zolldyck See #8708

infanf added a commit to infanf/yt-dlp that referenced this issue Jan 15, 2024
use f-strings
add headers to all requests
move language to url regex

resolves yt-dlp#8945
resolves yt-dlp#6643
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this issue Apr 21, 2024
- Add extractor for seasons

Closes yt-dlp#6643, Closes yt-dlp#8945
Authored by: infanf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-available There is patch available that should fix this issue. Someone needs to make a PR with it site-enhancement Feature request for some website
Projects
None yet
Development

No branches or pull requests

3 participants