New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ie/Turbo] Fix turbo extractor #8927
Conversation
I don't think the extractor should be changed like this to add playlist support. If you do want to add playlist support, that should be done in a dedicated extractor. However, I am not convinced that adding the RSS feeds like this is super useful, as most posts don't contain videos. In its current form, the code also seems broken? Do you have an example where parsing the RSS feeds would be useful? Looking at the site, it may be worth to split viously.com in to its own embed extractor instead. That would also deal more easily with the case where a single page contains multiple videos. And as a added bonus, it would also work on other sites using that CDN. |
Thanks a bunch for the feedback @seproDev, it all makes perfect sense to me! Removing the old Turbo extractor too since it's broken anyway. |
20fa5d7
to
d7c1751
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't force push
Replaces Turbo extractor Authored by: nbr23, seproDev Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
The Turbo site has changes, and the extractor is currently broken. This fixes it, and adds support for "playlists" (through their RSS feeds).
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?