New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CapitalTVCy] Add Capital TV Cyprus extractor #8948
Conversation
I updated the code and now works as an embed extractor that can detect the elementor video elements on all pages. It can also detect other keys as you mentioned. I also added the possibility to download playlists. In the page I was originally working the embed videos are not an elementor playlist so I couldn't download them. I added a new test that successfully downloads elementor playlist from another page |
Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
hey @seproDev. I saw that you've finished reviewing my pull request. Just wanted to check in and see if there's anything else you need from me to get it merged. Let me know if there are any more changes needed! |
Nothing is needed from you right now. The PR looks good from my side, but to be merged, a maintainer will also need to review it. They may raise additional things, I didn't catch. This will happen as time permits. |
Authored by: pompos02, seproDev Co-authored-by: sepro <4618135+seproDev@users.noreply.github.com>
Description of your pull request and other information
This pull request adds a new extractor for Capital TV Cyprus (CapitalTVCy). The extractor handles the extraction of YouTube video URLs embedded in the web pages of Capital TV Cyprus. This implementation ensures that users can download videos hosted on capitaltv.cy, which are embedded from YouTube.
The extractor parses the webpage to find the YouTube URL in the data-settings attribute of the video element and then delegates the actual video downloading to the YouTube extractor.
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?