Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German ADN Site doesn't work with cookies #9067

Closed
9 of 11 tasks
brainiac13 opened this issue Jan 25, 2024 · 6 comments · Fixed by #9068
Closed
9 of 11 tasks

German ADN Site doesn't work with cookies #9067

brainiac13 opened this issue Jan 25, 2024 · 6 comments · Fixed by #9068
Labels
account-needed Account details are needed to test/fix this site-bug Issue with a specific website

Comments

@brainiac13
Copy link

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

  • I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

Region

Germany

Provide a description that is worded well enough to be understood

The German ADN Site support was added last week but it doesn't work. Maybe something changed on the website.

I just tried to download: https://animationdigitalnetwork.de/video/my-instant-death-ability-is-so-overpowered-no-one-in-this-other-world-stands-a-chance-against-me/24108-folge-1-mort-subite

Thank you for your great work.

Provide verbose output that clearly demonstrates the problem

  • Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
  • If using API, add 'verbose': True to YoutubeDL params instead
  • Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output

[debug] Command-line config: ['-vU', '--cookies-from-browser', 'firefox', 'https://animationdigitalnetwork.de/video/my-instant-death-ability-is-so-overpowered-no-one-in-this-other-world-stands-a-chance-against-me/24108-folge-1-mort-subite']
Extracting cookies from firefox
[debug] Extracting cookies from: "C:\Users\vm\AppData\Roaming\Mozilla\Firefox\Profiles\6zzghx8w.default-release\cookies.sqlite"
Extracted 241 cookies from firefox
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version nightly@2024.01.23.232723 from yt-dlp/yt-dlp-nightly-builds [5f25f348f] (win_exe)
[debug] Python 3.8.10 (CPython AMD64 64bit) - Windows-10-10.0.19045-SP0 (OpenSSL 1.1.1k  25 Mar 2021)
[debug] exe versions: ffmpeg 6.1.1-full_build-www.gyan.dev (setts)
[debug] Optional libraries: Cryptodome-3.20.0, brotli-1.1.0, certifi-2023.11.17, mutagen-1.47.0, requests-2.31.0, sqlite3-3.35.5, urllib3-2.1.0, websockets-12.0
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests, websockets
[debug] Loaded 1819 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp-nightly-builds/releases/latest
Latest version: nightly@2024.01.23.232723 from yt-dlp/yt-dlp-nightly-builds
yt-dlp is up to date (nightly@2024.01.23.232723 from yt-dlp/yt-dlp-nightly-builds)
[ADN] Extracting URL: https://animationdigitalnetwork.de/video/my-instant-death-ability-is-so-overpowered-no-one-in-this-other-world-stands-a-chance-against-me/24108-folge-1-mort-subite
[ADN] 24108: Downloading player config JSON metadata
[ADN] 24108: Downloading access token
[ADN] 24108: Downloading links JSON metadata
[ADN] 24108: Downloading vostde mobile JSON metadata
WARNING: [ADN] Unable to download JSON metadata: HTTP Error 404: Not Found
[ADN] 24108: Downloading vostde sd JSON metadata
WARNING: [ADN] Unable to download JSON metadata: HTTP Error 404: Not Found
[ADN] 24108: Downloading additional video metadata
ERROR: [ADN] 24108: No video formats found!; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
Traceback (most recent call last):
  File "yt_dlp\YoutubeDL.py", line 1586, in wrapper
  File "yt_dlp\YoutubeDL.py", line 1742, in __extract_info
  File "yt_dlp\YoutubeDL.py", line 1801, in process_ie_result
  File "yt_dlp\YoutubeDL.py", line 2780, in process_video_result
  File "yt_dlp\YoutubeDL.py", line 1084, in raise_no_formats
yt_dlp.utils.ExtractorError: [ADN] 24108: No video formats found!; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
@brainiac13 brainiac13 added site-bug Issue with a specific website triage Untriaged issue labels Jan 25, 2024
@bashonly
Copy link
Member

cc @infanf

@bashonly bashonly added the account-needed Account details are needed to test/fix this label Jan 25, 2024
@infanf
Copy link
Contributor

infanf commented Jan 25, 2024

Cookies authorization doesn't work with ADN (also doesn't work with the French site). Try username and password instead.

@bashonly
Copy link
Member

is this check not effective?

user = options['user']
if not user.get('hasAccess'):
self.raise_login_required()

we also need to change it to self.raise_login_required(method='password')

@infanf
Copy link
Contributor

infanf commented Jan 25, 2024

The ADN API provides dead links for some formats on the German site. I guess this is one of the reasons why it is still in Beta. If you are not logged in or don't have a subscription, the formats you would be able to watch are the formats that are not available.
Currently there is no free German content, so we could just hardcode the login requirement for .de Links. But this may change once the site launches officially. There was free content a few weeks ago, so this may change at any time.

@brainiac13
Copy link
Author

Cookies authorization doesn't work with ADN (also doesn't work with the French site). Try username and password instead.

Thank you. With username and password it works.
I didn't find anything regarding which login method is working for different supported Sites.
I thought "Cookies authorization" would be the best way.

@bashonly bashonly removed the triage Untriaged issue label Jan 25, 2024
@bashonly bashonly changed the title German ADN Site isn't working German ADN Site doesn't work with cookies Jan 25, 2024
infanf added a commit to infanf/yt-dlp that referenced this issue Jan 25, 2024
ADN DE requires an account and subscription for all videos
add error message for missing subscription case if logged in
@infanf
Copy link
Contributor

infanf commented Jan 26, 2024

FYI: cookies won't work because ADN uses localStorage instead of cookies to store user information

bashonly pushed a commit that referenced this issue Jan 28, 2024
FletcherD pushed a commit to FletcherD/yt-dlp that referenced this issue Feb 14, 2024
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this issue Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
account-needed Account details are needed to test/fix this site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants