[ie/Vbox7] Fix extractor #9100
[ie/Vbox7] Fix extractor #9100
Conversation
yt_dlp/extractor/vbox7.py
Outdated
| if '.mp4' in data['src']: | ||
| base_url = data['src'].rpartition('_')[0] | ||
| else: | ||
| base_url = data['src'].rpartition('.')[0] |
There was a problem hiding this comment.
what do some data['src'] values look like?
There was a problem hiding this comment.
This depends on the video. As far as I can tell for older videos:
"https://media34.vbox7.com/sl/KWDFgB4GVvBbRXryw8afsw/1706738400/24/249bb972c2/249bb972c2_720.mp4"
For newer videos:
"https://edge349.vbox7.com/sl/SCfALacEV7f-Cbbs7iqbrQ/1706738400/3e/3e18bac5ad/3e18bac5ad.mpd"
For removed/broken(?) videos:
"" or "blank"
Closes yt-dlp#1098, Closes yt-dlp#5661 Authored by: seproDev
| 'uploader': 'svideteliat_ot_varshava', | ||
| 'view_count': int, | ||
| 'timestamp': 1360215023, | ||
| 'thumbnail': 'https://i49.vbox7.com/design/iconci/png/noimg6.png', |
There was a problem hiding this comment.
Really? noimg6.png isn't a likely name for a useful image (and the image isn't). Should it be filtered out?
I get:
'thumbnail': 'https://i49.vbox7.com/o/249/249bb972c20.jpg',
and that is an image that looks like a frame of the video.
There was a problem hiding this comment.
I added this to #8968. I am not sure why the API responded like this when I wrote the extractor. Maybe the image took some time to be generated?
We will have to see how many of the videos remain in ~4 days, when the site will supposedly delete most user-generated content.
* changes from yt-dlp/yt-dlp#9100 (thx seproDev): - attempt HLS extraction - re-enable XFF - test `view_count`, `duration` extraction * improve commenting, error checks
* changes from yt-dlp/yt-dlp#9100 (thx seproDev): - attempt HLS extraction - re-enable XFF - test `view_count`, `duration` extraction * improve commenting, error checks
* changes from yt-dlp/yt-dlp#9100 (thx seproDev): - attempt HLS extraction - re-enable XFF - test `view_count`, `duration` extraction * improve commenting, error checks
Closes yt-dlp#1098, Closes yt-dlp#5661 Authored by: seproDev
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Workaround for Vbox7 while DASH http ranges are not yet supported. Works by modifying the URL to get direct http and hls urls.
Fixes #1098
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?