New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ie/Vbox7] Fix extractor #9100
Merged
Merged
[ie/Vbox7] Fix extractor #9100
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6c525ef
[ie/Vbox7] Fix extractor
seproDev e77f953
Fix md5
seproDev cb45e61
Adjust base url extraction
seproDev c0ba87d
Check for unavailable videos
seproDev 1c283fe
Add src_url var
seproDev 634b06c
Add geo restriction check
seproDev edd1cc7
Adjust geo restriction detection
seproDev File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really?
noimg6.png
isn't a likely name for a useful image (and the image isn't). Should it be filtered out?I get:
and that is an image that looks like a frame of the video.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this to #8968. I am not sure why the API responded like this when I wrote the extractor. Maybe the image took some time to be generated?
We will have to see how many of the videos remain in ~4 days, when the site will supposedly delete most user-generated content.