-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ie/NHKRadiru] Switch to new metadata API #10106
Conversation
seems better to use aa_vinfo in the episode info bit, then no matter what happens with the extended metadata the fallback will get through
Authored by: bashonly
Authored by: bashonly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and pushed changes, but here's a retrospective review in case you're wondering why I did some things
All LGTM, + I checked the I was originally going to try and put the old/news code in |
thank you 👍 |
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
NHK changed the metadata API Radiru uses. It didn't matter for a few weeks, but they've taken away the old API now, so the extractor is broken.
This PR switches to the new API. It also improves the extended metadata handling a bit, since some of the metadata is now only available there.
It also breaks radio news, since they're still on the old system. but that's a whole can of worms which I don't want to get into right now. As a temporary measure, people can use the podcast version https://www.nhk.or.jp/s-media/news/podcast/list/v1/all.xml.
I should probably note, the original idea when I wrote most of this was to have the extended metadata thing be the "one true source"- but then I encountered a programme that didn't exist on the extended metadata thing, so I had to backtrack
so it might be a little rough around the edges in that regard
most of the metadata is still available from the fallback (at least the bits i use in my filename template 🚎)
Fixes #10105
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?