Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bilibili] Fix extractor #1716

Merged
merged 4 commits into from
Nov 30, 2021
Merged

[Bilibili] Fix extractor #1716

merged 4 commits into from
Nov 30, 2021

Conversation

u-spec-png
Copy link
Contributor

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Closes #1714

@pukkandan pukkandan added the site-bug Issue with a specific website label Nov 19, 2021
@Ashish0804
Copy link
Contributor

Changing id that too for such old and famous extractor is a no-no imo
Are u sure there's no way to keep same ids?

@u-spec-png
Copy link
Contributor Author

u-spec-png commented Nov 19, 2021

Changing id that too for such old and famous extractor is a no-no imo Are u sure there's no way to keep same ids?

Idk what is the cause but that's what extractor returns otherwise test will fail.

@u-spec-png u-spec-png changed the title [Bilbili] Fix extractor [Bilibili] Fix extractor Nov 26, 2021
@pukkandan
Copy link
Member

pukkandan commented Nov 27, 2021

The test failing is clearly not caused by your changes.

But changing the test to fit the code without understanding why it fails is not the right practice. Maybe you are right and the test is just wrong. Or maybe, this was never the intended behavior and the issue is in the code

This seems to be actually a bug in the anthology code. This video's extracted id changes depending on whether --no-playlist was given or not. See #1819

@pukkandan pukkandan merged commit ac0efab into yt-dlp:master Nov 30, 2021
pukkandan added a commit that referenced this pull request Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bilibili] Unable to extract title
3 participants