[bbc] Get all available formats, deprioritize audio description #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Audio description is available in a separate manifest which is SD only. Sometimes BBC iPlayer will mistakenly mark it as the default format too. Example: yt-dlp --playlist-items 1 -F "https://www.bbc.co.uk/iplayer/episodes/p09twdp8/showtrial?seriesId=p09twdth" I've changed the extractor to return all available formats, add the "types" field to format notes, and deprioritize audio described tracks.
pukkandan
approved these changes
Nov 19, 2021
pukkandan
reviewed
Nov 19, 2021
0xallie
force-pushed
the
iplayer-fix-audiodesc
branch
from
a59b892
to
db670b9
Compare
gaming-hacker
added a commit
to gaming-hacker/yt-dlp
that referenced
this pull request
Nov 23, 2021
* commit 'ff51ed588fa75256b98ead67bdef7edda08b66f0': (45 commits) Clarify video/audio-only formats in -F Related: yt-dlp#1759 [jsinterp] Fix splice to handle float Needed for new youtube js player f1ca6900 Closes yt-dlp#1767 [tv2] Expand valid URL Closes yt-dlp#1764 [sbs] Fix for movies and livestreams Closes yt-dlp#1640 [itv] Fix for Python 3.6/3.7 Closes yt-dlp#1758 [extractor] Extract `average_rating` from JSON-LD Eg: Crunchyroll [ARDBetaMediathek] Handle new URLs Adapted from ytdl-org/youtube-dl@8562218 Closes yt-dlp#1601 Ensure path for link files exists (yt-dlp#1755) Authored by: Zirro [mediaklikk] Expand valid URL Partial fix for yt-dlp#1409 [vimeo] Add fallback for config URL Closes yt-dlp#1662 [downloader/ffmpeg] Fix for direct videos inside mpd manifests Closes yt-dlp#1751 [WDR] Expand valid URL Closes yt-dlp#1749 [xvideos] Detect embed URLs (yt-dlp#1729) [CozyTV] Add extractor (yt-dlp#1727) [willow] Add extractor (yt-dlp#1723) Fix `--check-formats` for `mhtml` Closes yt-dlp#1709 [utils] Fix error when copying `LazyList` [utils] Fix `PagedList` Bug in d8cf8d9 [utils] Allow alignment in `render_table` and add tests [bbc] Get all available formats (yt-dlp#1717) ... # Conflicts: # README.md # yt_dlp/utils.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Audio description is available in a separate manifest which is (at least sometimes) SD only. Sometimes BBC iPlayer will mistakenly mark it as the default format too.
Example:
I've changed the extractor to return all available formats, add the
typesfield to format notes, and deprioritize audio described tracks.Note: In this example audio description is tagged as
DubbedAudioDescribed, but I check if the type containsAudioDescribedanywhere like get_iplayer does just in case.