New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes and improvements in general and to external downloaders #173

Merged

pukkandan merged 10 commits into yt-dlp:master from damianoamatruda:master

Mar 20, 2021

Contributor

damianoamatruda commented Mar 15, 2021

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
Searched the bugtracker for similar pull requests
Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

I am the original author of this code and I am willing to release it under Unlicense
I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Bug fix
Improvement
New extractor
New feature

pukkandan reviewed

View reviewed changes

yt_dlp/downloader/hls.py Outdated Show resolved Hide resolved

yt_dlp/downloader/external.py Outdated Show resolved Hide resolved

yt_dlp/downloader/external.py Show resolved Hide resolved

pukkandan reviewed

View reviewed changes

Member

pukkandan left a comment

1d27378 This only makes merging with upstream code more difficult while providing no actual benefit
f74440d Please explain this commit. I don't understand how the current implementation is wrong

pukkandan reviewed

View reviewed changes

yt_dlp/downloader/hls.py Outdated Show resolved Hide resolved

Contributor Author

damianoamatruda commented Mar 16, 2021

1d27378 This only makes merging with upstream code more difficult while providing no actual benefit

For me it’s a matter of consistency, but I accept your observation

pukkandan and others added 10 commits

March 20, 2021 09:15


          [splitchapters] Fix for older ffmpeg

fc2d873

Older versions of ffmpeg doesn't allow `-to` as an input option
Closes #180


          [documentation] Add SplitChapters to --ppa

0874a88


          Make sure post_hook gets the final filename

a533c3f


          [aria2c] Better default arguments

0539def


          [aria2c] Support retry/abort unavailable fragments

fc792df

Co-authored by: Damiano Amatruda <damiano.amatruda@outlook.com>


          Use headers and cookies when downloading subtitles

f7329e3


          Parse resolution in info dictionary

fd5e84d


          Merge webm formats into mkv if thumbnails are to be embedded

34511bb

Co-authored by: Damiano Amatruda <damiano.amatruda@outlook.com>


          Embed video URL metadata inside MP4

b081f7a

`mp4` has `comment` and `synopsis`; the synopsis is expected to have the long description
So we save the `webpage_url` to `comment` and `description` to `synopsis`

Related: ytdl-org/youtube-dl#28478

Co-authored by: Damiano Amatruda <damiano.amatruda@outlook.com>


          More consistent warning messages

86bdd27

Co-authored by: Damiano Amatruda <damiano.amatruda@outlook.com>

pukkandan merged this pull request into yt-dlp:master

pukkandan added a commit that referenced this pull request


          [aria2c] Support retry/abort unavailable fragments (#173)

fe84528

Co-authored by: Damiano Amatruda <damiano.amatruda@outlook.com>

pukkandan pushed a commit that referenced this pull request


          Use headers and cookies when downloading subtitles (#173)

pukkandan pushed a commit that referenced this pull request


          Parse resolution in info dictionary (#173)

pukkandan added a commit that referenced this pull request


          Merge webm formats into mkv if thumbnails are to be embedded (#173)

4d971a1

Co-authored by: Damiano Amatruda <damiano.amatruda@outlook.com>

pukkandan added a commit that referenced this pull request


          Embed video URL metadata inside MP4 (#173)

cd9b384

`mp4` has `comment` and `synopsis`; the synopsis is expected to have the long description
So we save the `webpage_url` to `comment` and `description` to `synopsis`

Related: ytdl-org/youtube-dl#28478

Co-authored by: Damiano Amatruda <damiano.amatruda@outlook.com>

pukkandan added a commit that referenced this pull request


          More consistent warning messages (#173)

beb4b92

Co-authored by: Damiano Amatruda <damiano.amatruda@outlook.com>

pukkandan added a commit that referenced this pull request


          Revert "Merge webm formats into mkv if thumbnails are to be embedded (#…

3b29791

…173)"

This reverts commit 4d971a1 by @damianoamatruda
Closes #500

This was wrongly checking for `write_thumbnail`

pukkandan added a commit that referenced this pull request


          Merge webm formats into mkv if thumbnails are to be embedded

4e3b637

This was originally implemented in 4d971a1 (#173) by @damianoamatruda
but was reverted in 3b29791
since it was unintentionally being triggered for `write_thumbnail` (See #500)

nixxo referenced this pull request in nixxo/yt-dlp


          [aria2c] Support retry/abort unavailable fragments (#173)

db98377

Co-authored by: Damiano Amatruda <damiano.amatruda@outlook.com>

nixxo referenced this pull request in nixxo/yt-dlp


          Use headers and cookies when downloading subtitles (#173)

a0bbeef

nixxo referenced this pull request in nixxo/yt-dlp


          Parse resolution in info dictionary (#173)

b9a93af

nixxo referenced this pull request in nixxo/yt-dlp


          Merge webm formats into mkv if thumbnails are to be embedded (#173)

c1e3104

Co-authored by: Damiano Amatruda <damiano.amatruda@outlook.com>

nixxo referenced this pull request in nixxo/yt-dlp


          Embed video URL metadata inside MP4 (#173)

b22a11c

`mp4` has `comment` and `synopsis`; the synopsis is expected to have the long description
So we save the `webpage_url` to `comment` and `description` to `synopsis`

Related: ytdl-org/youtube-dl#28478

Co-authored by: Damiano Amatruda <damiano.amatruda@outlook.com>

nixxo referenced this pull request in nixxo/yt-dlp


          More consistent warning messages (#173)

b17dd58

Co-authored by: Damiano Amatruda <damiano.amatruda@outlook.com>

nixxo referenced this pull request in nixxo/yt-dlp


          Revert "Merge webm formats into mkv if thumbnails are to be embedded (#…

61020fa

…173)"

This reverts commit c1e3104 by @damianoamatruda
Closes yt-dlp#500

This was wrongly checking for `write_thumbnail`

nixxo referenced this pull request in nixxo/yt-dlp


          Merge webm formats into mkv if thumbnails are to be embedded

ce31f06

This was originally implemented in c1e3104 (#173) by @damianoamatruda
but was reverted in 61020fa
since it was unintentionally being triggered for `write_thumbnail` (See yt-dlp#500)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment