[youporn] Fix extraction of metadata

[marieell]

Before submitting a pull request make sure you have:

• At least skimmed through contributing guidelines including yt-dlp coding conventions
• Searched the bugtracker for similar pull requests
• Checked the code with flake8

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

• I am the original author of this code and I am willing to release it under Unlicense
• I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

• Bug fix
• Improvement
• New extractor
• New feature

---

Closes #2701. Youporn sends a JS challenge with TLS1.3-

[pukkandan]

Outdated

1. The idea of creating a new context is interesting, but more consideration must be given for how it is implemented. (Related: [Feature Request]Ability to use a separate file which stores names of cookie files to use and either extractor/domain #258, [options] Add --legacy-server-connect #778, [ceskatelevize.cz] Cannot download manifest - SSLV3_ALERT_HANDSHAKE_FAILURE #2043). For the time-being, implement PROTOCOL_TLSv1_2 into --legacy-server-connect instead. You can catch the relevant error in the extractor and ask user to apply this option.
2. Why use context.post_handshake_auth? afaik, it is not applicable for us

---

3. Use merge_dicts instead of all if not data[...]: data[...] = ... in extractor code. The same can be used for the final update

[pukkandan]

#2701 has been fixed in a different way, so only the site enhancements is remaining from this PR

[marieell]

3. Use merge_dicts instead of all if not data[...]: data[...] = ... in extractor code. The same can be used for the final update

But that would always execute all these extractions, even if they are not necessary?

[pukkandan]

Is that an issue?

[marieell]

It's a lot of possibly unneeded string matching for in my opinion not much of a style improvement. Well. What do you want it to look like?

data = merge_dicts(data, { 'title': self._html_search_regex(
// …
)})

[pukkandan]

Ive pushed some changes. pls add a test

[pukkandan]

Actually, I just realized that the whole PR is really just one line. Everything else is unnecessary changes!

[marieell]

Alright, I squashed the commits.

[pukkandan]

That was not necessary. Pls avoid force pushing in future

pls add a test

?

[marieell]

Pls avoid force pushing in future

Is that documented somewhere? Most projects I know strongly encourage cleaning up commits in PRs.

[pukkandan]

Is that documented somewhere?

No

Most projects I know strongly encourage cleaning up commits in PRs.

It makes reviewing harder. And we squash and merge anyway