Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[downloader/external] Fix WgetFD proxy #3152

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

coletdjnz
Copy link
Member

@coletdjnz coletdjnz commented Mar 22, 2022

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

From ytdl-org/youtube-dl#29343

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

wget --proxy argument accepts a bool for enable/disabling the proxy, not for setting what proxy to use.

so before it was sending the proxy url as a normal url to download...

see ytdl-org/youtube-dl#29343 for more details

@coletdjnz coletdjnz added the bug Bug that is not site-specific label Mar 22, 2022
@pukkandan pukkandan merged commit 8a23db9 into yt-dlp:master Mar 22, 2022
@coletdjnz coletdjnz deleted the fix/wget-proxy branch March 23, 2022 09:10
dirkf added a commit to ytdl-org/youtube-dl that referenced this pull request Feb 21, 2024
From PR (defunct source), closes #29343.
Matches yt-dlp/yt-dlp#3152
Thx former user kikuyan.
dirkf added a commit to ytdl-org/ytdl-nightly that referenced this pull request Feb 22, 2024
From PR (defunct source), closes #29343.
Matches yt-dlp/yt-dlp#3152
Thx former user kikuyan.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug that is not site-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants