Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downloader for slide streams #343

Closed
wants to merge 13 commits into from
Closed

Downloader for slide streams #343

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
2089ea5
[downloader/mhtml] New downloader
fstirlitz May 23, 2021
c5df915
[mediasite] Extract slides
fstirlitz May 23, 2021
89124e6
[common] Extract thumbnail stream from DASH manifests
fstirlitz May 23, 2021
2eaa599
Merge branch 'master' into slideshows
pukkandan Jun 7, 2021
407878b
Remove "Unknown MIME" warnings from tests
pukkandan Jun 7, 2021
5f323f1
Remove `_download_params`
pukkandan Jun 7, 2021
bda743f
Add `msec` to duration
pukkandan Jun 7, 2021
4b87c0e
`escapeHTML` is a utility
pukkandan Jun 7, 2021
891ab61
[cleanup]
pukkandan Jun 7, 2021
58ca4c9
[mhtml] `real_download` should return `True` on success
pukkandan Jun 12, 2021
a662714
Remove `vcodec`
pukkandan Jun 12, 2021
7e35452
Merge remote-tracking branch 'origin/master' into slideshows
pukkandan Jun 12, 2021
b4fa676
The images are not necessarily jpeg
pukkandan Jun 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions yt_dlp/downloader/mhtml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,8 @@ def real_download(self, filename, info_dict):
fragment_base_url = info_dict.get('fragment_base_url')
fragments = info_dict['fragments'][:1] if self.params.get(
'test', False) else info_dict['fragments']
title = info_dict['_download_params'].get('title', fragment_base_url)
origin = info_dict['_download_params'].get('origin')
title = info_dict['title']
origin = info_dict['webpage_url']

ctx = {
'filename': filename,
Expand Down
9 changes: 1 addition & 8 deletions yt_dlp/extractor/mediasite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ def _extract_urls(webpage):
r'(?xi)<iframe\b[^>]+\bsrc=(["\'])(?P<url>(?:(?:https?:)?//[^/]+)?/Mediasite/Play/%s(?:\?.*?)?)\1' % _ID_RE,
webpage)]

def __extract_slides(self, *, stream_id, snum, Stream, duration, images, title, origin):
def __extract_slides(self, *, stream_id, snum, Stream, duration, images):
slide_base_url = Stream['SlideBaseUrl']

fname_template = Stream['SlideImageFileNameTemplate']
Expand Down Expand Up @@ -167,11 +167,6 @@ def __extract_slides(self, *, stream_id, snum, Stream, duration, images, title,
'format_note': 'Slides',
'fragments': fragments,
'fragment_base_url': slide_base_url,
'_download_params': {
'duration': duration,
fstirlitz marked this conversation as resolved.
Show resolved Hide resolved
'title': title,
'origin': origin,
},
}

def _real_extract(self, url):
Expand Down Expand Up @@ -258,8 +253,6 @@ def _real_extract(self, url):
Stream=Stream,
duration=presentation.get('Duration'),
images=images,
title=title,
origin=url
))

# disprefer 'secondary' streams
Expand Down