Fix redirect HTTP method handling #3577
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Backported from #2861
Currently YoutubeDLRedirectHandler (which is based off the urllib redirect handler) makes all redirect requests with GET method, regardless of the original method and status code. This behaviour is inconsistent with standards and what browsers usually do.
This PR brings the method handling in line with RFC7231 and RFC7538 and what browsers tend to do. Requests v3 also does essentially the same thing.
This also fixes 307 & 308 redirects (they must retain the original method) - python/cpython#91306
The main changes are: