Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AbemaTV] post network stack overhaul #3615

Closed

Conversation

Lesmiscore
Copy link
Contributor

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

Except the code from #2861

What is the purpose of your pull request?


Description of your pull request and other information

DO NOT MERGE BEFORE #2861

This applies needed fix after #2861 for AbemaTV extractors.

fstirlitz and others added 30 commits February 18, 2022 14:13
# Conflicts:
#	yt_dlp/downloader/fragment.py
#	yt_dlp/extractor/youtube.py
# Conflicts:
#	README.md
#	yt_dlp/YoutubeDL.py
#	yt_dlp/__init__.py
#	yt_dlp/downloader/fragment.py
#	yt_dlp/downloader/http.py
#	yt_dlp/extractor/common.py
#	yt_dlp/extractor/facebook.py
#	yt_dlp/extractor/fc2.py
#	yt_dlp/extractor/instagram.py
#	yt_dlp/extractor/mgtv.py
#	yt_dlp/extractor/mildom.py
#	yt_dlp/extractor/openload.py
#	yt_dlp/extractor/rtve.py
#	yt_dlp/extractor/rumble.py
#	yt_dlp/extractor/soundcloud.py
#	yt_dlp/extractor/tiktok.py
#	yt_dlp/extractor/vimeo.py
#	yt_dlp/utils.py
# Conflicts:
#	yt_dlp/YoutubeDL.py
#	yt_dlp/extractor/common.py
#	yt_dlp/extractor/viu.py
#	yt_dlp/postprocessor/sponsorblock.py
#	yt_dlp/utils.py
Make it much more simple
Copy link
Member

@coletdjnz coletdjnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though there is still a lot of work to do on the network overhaul, thanks for doing this. gives me some insight into things

these are just some notes mostly for the network overhaul pr at this time

yt_dlp/networking/_urllib.py Show resolved Hide resolved
yt_dlp/networking/common.py Show resolved Hide resolved
yt_dlp/extractor/abematv.py Outdated Show resolved Hide resolved
yt_dlp/utils.py Outdated Show resolved Hide resolved
@pukkandan pukkandan force-pushed the master branch 2 times, most recently from a63ff77 to b14d523 Compare May 18, 2022 03:35
@pukkandan pukkandan mentioned this pull request Jun 24, 2022
9 tasks
@pukkandan pukkandan force-pushed the master branch 2 times, most recently from ee280c7 to 7aeda6c Compare May 24, 2023 18:09
@coletdjnz coletdjnz added the stale-pr PR that has been pending fixes for a long time label Sep 9, 2023
@coletdjnz
Copy link
Member

Closing as OP inactive and this branch is very outdated (it is based on an early version of the networking rework).

If someone wants to pick this up I recommend creating a new branch from master and going from there.

@coletdjnz coletdjnz closed this Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale-pr PR that has been pending fixes for a long time
Projects
Status: networking
Development

Successfully merging this pull request may close these issues.

None yet

3 participants