Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NokiaTune] Add extractor #4259

Closed
wants to merge 1 commit into from
Closed

Conversation

Ashish0804
Copy link
Contributor

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Description of your pull request and other information

DESCRIPTION

Closes #4028

@fstirlitz
Copy link
Contributor

That’s hardly the only contest held by AudioDraft. Just a handful of links:

And there are even more which don’t have their own domains, for which a typical entry URI seems to look like https://www.audiodraft.com/contests/570-Score-A-Video-Surprise-Us#entries&eid=30138.

I don’t think it would even be that much effort to have the extractor cover those cases too. Why did you choose to submit this in such a half-finished state?

@Ashish0804
Copy link
Contributor Author

Are u retarded enough to not see the linked issue?
He only mentioned nokiatune so that's all i added.

@Ashish0804
Copy link
Contributor Author

U are free to take this PR forward.

@Ashish0804 Ashish0804 closed this Jul 6, 2022
@Ashish0804 Ashish0804 deleted the nokiatune branch July 6, 2022 05:55
@pukkandan pukkandan added site-request Request to support a new website closed-pr (Partially) valid PR that was closed by OP labels Jul 6, 2022
@fstirlitz fstirlitz mentioned this pull request Jul 6, 2022
9 tasks
@fstirlitz
Copy link
Contributor

Are u retarded enough to not see the linked issue?

I’m not much of a fan of language policing, but that was uncalled for.

I did, in fact, read the other tickets, and no, I don’t think that justifies doing a half-hearted job. When someone writes a ticket requesting support for a media host, with example URLs, we don’t write an extractor that works only on the examples given. Especially when covering the entire offering from the host is not even that hard. (It took me less than an hour or so to extend that extractor.) At the risk of me sounding hypocritical now, to do so would be acting like a jackass.

pukkandan pushed a commit that referenced this pull request Jul 9, 2022
Based on #4259
Closes #4028

Authored by: fstirlitz, Ashish0804
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-pr (Partially) valid PR that was closed by OP site-request Request to support a new website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AudioDraft
3 participants