Webpage-based extraction - Part 2 #4517
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pukkandan
force-pushed
the
features/generic2
branch
from
2ba3fe3
to
3c068f7
Compare
and split download tests so they can be more easily run in CI Authored by: coletdjnz
Closes yt-dlp#4291 Authored by: coletdjnz, pukkandan
`Brightcove` is difficult to migrate because it's subclasses may depend on the signature of the current functions. So it is left as-is for now Note: Tests have not been migrated
This one should be safe. The other jw player embed detection may not be, so will leave it for now)
Note the ones with FIXME need addressing. *working as in extracts a correct embed from the extractor. Whether from there it works doesn't matter.
pukkandan
force-pushed
the
features/generic2
branch
from
3c068f7
to
8f719d3
Compare
|
todo: #4307 (comment) |
9 tasks
10 tasks
pukkandan
force-pushed
the
master
branch
2 times, most recently
from
ee280c7
to
7aeda6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Part 1 (#4307) for details
On top of #4307, This PR aims to address objectives (1g)/(2) and improve the related testing framework
@coletdjnz I am preparing to merge the first PR. Except for any bugfixes, add all new changes to this instead