Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add color to '* has already been recorded in the archive' message #5138

Merged
merged 8 commits into from Jul 15, 2023
Merged

Feat: add color to '* has already been recorded in the archive' message #5138

Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
050d241
Feat: add color to '* has already been recorded in the archive' message'
aaruni96 Oct 4, 2022
f7a5071
Cleanup: make flake8 happy
aaruni96 Oct 4, 2022
9fb87e5
Use f-strings, remove unnecessary color
aaruni96 Oct 4, 2022
dea1284
Add color to the other instance of this reason
aaruni96 Oct 5, 2022
35e2e9f
Inline f-string, add video id to output
aaruni96 Jan 2, 2023
e91ade7
Apply suggestions from code review
pukkandan Jul 15, 2023
256294e
Merge remote-tracking branch 'origin/master' into pr/5138
pukkandan Jul 15, 2023
c125125
cleanup
pukkandan Jul 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions yt_dlp/YoutubeDL.py
View file
Open in desktop
Expand Up @@ -1402,7 +1402,7 @@ def check_filter():
return None

if self.in_download_archive(info_dict):
reason = '%s has already been recorded in the archive' % video_title
reason = f'{self._format_screen(video_title, self.Styles.FILENAME)} has already been recorded in the archive'
Grub4K marked this conversation as resolved.
Show resolved Hide resolved
break_opt, break_err = 'break_on_existing', ExistingVideoReached
else:
reason = check_filter()
Expand Down Expand Up @@ -1459,7 +1459,10 @@ def extract_info(self, url, download=True, ie_key=None, extra_info=None,

temp_id = ie.get_temp_id(url)
if temp_id is not None and self.in_download_archive({'id': temp_id, 'ie_key': key}):
self.to_screen(f'[{key}] {temp_id}: has already been recorded in the archive')
self.to_screen(f'[{key}] '
f'{self._format_screen(temp_id, self.Styles.ID)}: '
'has already been recorded in the archive'
)
Grub4K marked this conversation as resolved.
Show resolved Hide resolved
pukkandan marked this conversation as resolved.
Show resolved Hide resolved
if self.params.get('break_on_existing', False):
raise ExistingVideoReached()
break
Expand Down