New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[XVideos] Support profiles, searches, channels and favorites #5153
base: master
Are you sure you want to change the base?
Conversation
Added: XVideosIE XVideosChannelIE XVideosPlaylistIE XVideosRelatedIE XVideosSearchIE
Example of downloading xvideos profile videos tab:
|
If you want to get this PR merged here directly, you must read through and obey our contributing guidelines (including removing pre-3.6 compat code). Otherwise, wait for it to be merged in ytdl, and I will port it here |
I have read the contributing guidelines & yt-dlp-coding-conventions but I'm very new in coding. So I guess I'll just wait. |
Would you be able/willing to make the necessary changes if I write a review? |
Yeah, of course. Sure. |
To start off, add tests - atleast one for each URL pattern |
Did you mean for |
No, I meant add test cases to the extractors |
You mean like this one?
|
@rum416 |
ee280c7
to
7aeda6c
Compare
You can use this userscript for the playlist page. It will record all video urls onto the current page into the localstorage variable "my_vid_urls". You have to clear this variable if it exists and then open every page of the playlist you want to download. Do not click too fast, wait for the page to load completely, otherwise some pages will not have time to record. Then copy variable "my_vid_urls" from Chrome Devtools to new file list.txt, and pass to yt-dlp like this: "yt-dlp -a list.txt"
|
@master-leonardo, I'd be happy to do that in the to-be-updated yt-dl PR but how would it be tested? |
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Imported from ytdl-org/youtube-dl#30774
The XVideos extractor supported single videos presented via various URL formats. The site also offers various playlist-like pages:
This PR tries to support extracting from those pages.
Added
/profiles
tab support by me.Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?