Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extractor/reddit] Add fallback format #5165

Merged
merged 3 commits into from Oct 7, 2022

Conversation

bashonly
Copy link
Member

@bashonly bashonly commented Oct 6, 2022

Some Reddit videos (hosted on v.redd.it) have a higher quality video format that was not being extracted.

fallback_url was already a field in the reddit_video JSON object: the extractor was previously using the value to find the video ID, but was not extracting the URL as a format. For some videos the fallback_url format's resolution can be up to 1080p, which is better than any formats found in the DASH MPD. I assume this is only the case with videos where the original source was 1080 or better.

Note: even though it is a direct http URL, the fallback_url is a video-only mp4 format, and Reddit seems to treat it like a DASH variant: the URL basename is usually DASH_1080.mp4 or DASH_{bitrate}.mp4

Fixes #5160

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@pukkandan pukkandan merged commit 2e565f5 into yt-dlp:master Oct 7, 2022
@bashonly bashonly deleted the reddit-formats-patch branch October 7, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reddit videos are not downloaded at the highest quality
2 participants