[extractor/reddit] Add fallback format #5165
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Reddit videos (hosted on v.redd.it) have a higher quality video format that was not being extracted.
fallback_url
was already a field in thereddit_video
JSON object: the extractor was previously using the value to find the video ID, but was not extracting the URL as a format. For some videos thefallback_url
format's resolution can be up to 1080p, which is better than any formats found in the DASH MPD. I assume this is only the case with videos where the original source was 1080 or better.Note: even though it is a direct http URL, the
fallback_url
is a video-only mp4 format, and Reddit seems to treat it like a DASH variant: the URL basename is usuallyDASH_1080.mp4
orDASH_{bitrate}.mp4
Fixes #5160
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?