[utils] traverse_obj: return [] if last path branches without default
#5170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pukkandan
reviewed
Oct 7, 2022
9 tasks
9 tasks
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
May 3, 2023
Thanks Grub4k for these: * traverse `Iterable`s, from yt-dlp/yt-dlp#6902, etc * traverse `set` key for transformations/filters, `re.Match` group names, from yt-dlp/yt-dlp@776995b, etc * traverse `re.Match`es, from yt-dlp/yt-dlp#5174 * always return list when branching, from yt-dlp/yt-dlp#5170
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
Jul 18, 2023
Thanks Grub4k for these: * traverse `Iterable`s, from yt-dlp/yt-dlp#6902, etc * traverse `set` key for transformations/filters, `re.Match` group names, from yt-dlp/yt-dlp@776995b, etc * traverse `re.Match`es, from yt-dlp/yt-dlp#5174 * always return list when branching, from yt-dlp/yt-dlp#5170
dirkf
added a commit
to ytdl-org/youtube-dl
that referenced
this pull request
Jul 19, 2023
Thanks Grub4k for these: * traverse `Iterable`s, from yt-dlp/yt-dlp#6902, etc * traverse `set` key for transformations/filters, `re.Match` group names, from yt-dlp/yt-dlp@776995b, etc * traverse `re.Match`es, from yt-dlp/yt-dlp#5174 * always return list when branching, from yt-dlp/yt-dlp#5170
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
It is common to see a pattern like
traverse_obj(obj, ...) or []since the default is currentlyNone.This can cause developers to fall into the trap of doing
for item in traverse_obj(obj, ...).This PR addresses this issue by defaulting to
[]if the last path did not match and no default was provided.Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Closes #5162