[Roblox] Add individual extractor #5178
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pukkandan
reviewed
Oct 8, 2022
Comment on lines
+101
to
+107
| # Assets have no file extension and use binary/octet-stream as Content-Type | ||
| pp = FFmpegPostProcessor(self._downloader) | ||
| self.to_screen(f'{asset_id}: Checking file format with ffprobe') | ||
| try: | ||
| metadata = pp.get_metadata_object(asset_file_url) | ||
| except PostProcessingError as err: | ||
| raise ExtractorError(err.msg, expected=True) |
There was a problem hiding this comment.
There's actually a feature request to support this in core code #613
That aside, is there no way to avoid this in the extractor?
There was a problem hiding this comment.
The most important metadata are setting acode/vcodec='none' and ext. I assume codec can be handled with asset_type
There was a problem hiding this comment.
You can only narrow down the formats, e.g. audio can only be uploaded as ogg/vorbis or mp3, and while video is most likely webm/vp9 (since video can only be uploaded by select ppl, we can't even be sure about this), the metadata hints at mp4 muxing being possible
pukkandan
force-pushed
the
master
branch
2 times, most recently
from
ee280c7
to
7aeda6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Partially solves #5049 and #3667
Intended to always download audio with basic metadata (when actually available, via webpage), and download video (via assetdelivery API) alongside music metadata (via toolbox/extra metadata API) when logged in
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?