Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check OSError when importing cryptodome #5482

Closed
wants to merge 2 commits into from
Closed

Check OSError when importing cryptodome #5482

wants to merge 2 commits into from

Conversation

DUOLabs333
Copy link

(The module may exist, but the so files might not).

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

(The module may exist, but the so files might not).
@coletdjnz
Copy link
Member

coletdjnz commented Nov 8, 2022

(The module may exist, but the so files might not).

Do you know why this happens? This sounds like an issue with your installation 😕

@DUOLabs333
Copy link
Author

No, I intentionally did that (I want to avoid C dependencies when possible. So, I want to set up a venv with yt-dlp without any non-Python dependencies).

@pukkandan
Copy link
Member

Why would you intentionally install a dependency improperly and expect us to handle that case? If you don't want the dependency, just don't install it at all

@DUOLabs333
Copy link
Author

DUOLabs333 commented Nov 9, 2022

Or, you can offer Cryptodome, mutagen, etc., as optional dependencies, which can be installed as yt_dlp[full].

@pukkandan
Copy link
Member

Most people would prefer to have these dependencies when just doing pip install yt-dlp. If pypa/setuptools#1139 was a thing, I would have put them behind extras. But unfortunately, pip does not currently provide a way to setup recommended/default dependencies.

Since yt-dlp has no mandatory dependencies at all, putting everything behind an extra only makes it harder for newbies with no real benefit. You can simply use --no-deps instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants