Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[daftsex] fix: update domain and embed player url #5966

Merged
merged 3 commits into from May 29, 2023

Conversation

JChris246
Copy link
Contributor

Description of your pull request and other information

This PR implements the fix, provided by @NiklasFarber1024, for #5881 by updating the VALID_URL regex with the new domain as well as updating the url for the embed player where the video parameters are parsed.

Fixes #5881

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@pukkandan pukkandan added NSFW site-bug Issue with a specific website labels Jan 5, 2023
@pukkandan
Copy link
Member

Update tests

@pukkandan pukkandan added the pending-fixes PR has had changes requested label Jan 6, 2023
- use skip instead of removing test data and adding only_matching
- remove verbose checking for video items
@pukkandan pukkandan force-pushed the master branch 2 times, most recently from ee280c7 to 7aeda6c Compare May 24, 2023 18:09
@Soebb
Copy link
Contributor

Soebb commented May 26, 2023

Please merge it!

@pukkandan pukkandan removed the pending-fixes PR has had changes requested label May 26, 2023
@pukkandan pukkandan merged commit fc5a7f9 into yt-dlp:master May 29, 2023
@JChris246 JChris246 deleted the fix/daftsex branch May 29, 2023 06:14
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NSFW site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

daftsex.com has changed it's domain to daft.sex
3 participants