Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[updater] Fixes the updater file removal on windows #5970

Merged
merged 2 commits into from
Jan 6, 2023

Conversation

Grub4K
Copy link
Member

@Grub4K Grub4K commented Jan 6, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Fixes the updater code and reverts the previous workaround which only worked for x64. These changes are tested on Windows 7 (6.1.7601-SP1) 32bit and Windows 11 (10.0.22000).

Fixes #5632

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@pukkandan pukkandan merged commit 5be214a into yt-dlp:master Jan 6, 2023
@Grub4K Grub4K deleted the fix/updater-5632 branch April 30, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Self update (win_x86): "ERROR: Unable to remove the old version"
2 participants