-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extractor/biliIntl] Add comment extraction #6079
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HobbyistDev
changed the title
[extractor/biliInt] Add comment extraction
[extractor/biliIntl] Add comment extraction
Jan 24, 2023
pukkandan
requested changes
Feb 12, 2023
pukkandan
added
site-enhancement
Feature request for some website
pending-fixes
PR has had changes requested
labels
Feb 12, 2023
commit 6bc9f84 Author: HobbyistDev <tesutonihon4@gmail.com> Date: Tue Jan 24 20:09:53 2023 +0900 add comment extraction support for user-generated content commit 419f01f Author: HobbyistDev <tesutonihon4@gmail.com> Date: Tue Jan 24 19:27:58 2023 +0900 add comment about `type` query commit 551d5bb Author: HobbyistDev <tesutonihon4@gmail.com> Date: Mon Jan 23 23:18:18 2023 +0900 remove comment commit 3a2b135 Author: HobbyistDev <tesutonihon4@gmail.com> Date: Mon Jan 23 23:17:48 2023 +0900 add timestamp metadata to comment commit 9aae5be Author: HobbyistDev <tesutonihon4@gmail.com> Date: Mon Jan 23 22:47:18 2023 +0900 add comment reply extraction commit d7f3c70 Author: HobbyistDev <tesutonihon4@gmail.com> Date: Mon Jan 23 19:39:57 2023 +0900 [extractor/biliIntl] Add comment extraction from api
HobbyistDev
force-pushed
the
biliIntl-comment
branch
from
February 14, 2023 12:20
8d70d42
to
8b37c58
Compare
Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Authored by: HobbyistDev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
This PR add comment extraction support for
BiliIntlIE
.Fixes #
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?