Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extractor/biliIntl] Add comment extraction #6079

Merged
merged 18 commits into from
Apr 12, 2023

Conversation

HobbyistDev
Copy link
Contributor

@HobbyistDev HobbyistDev commented Jan 23, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

This PR add comment extraction support for BiliIntlIE.

Fixes #

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@HobbyistDev HobbyistDev changed the title [extractor/biliInt] Add comment extraction [extractor/biliIntl] Add comment extraction Jan 24, 2023
yt_dlp/extractor/bilibili.py Outdated Show resolved Hide resolved
yt_dlp/extractor/bilibili.py Outdated Show resolved Hide resolved
yt_dlp/extractor/bilibili.py Outdated Show resolved Hide resolved
yt_dlp/extractor/bilibili.py Outdated Show resolved Hide resolved
yt_dlp/extractor/bilibili.py Outdated Show resolved Hide resolved
yt_dlp/extractor/bilibili.py Outdated Show resolved Hide resolved
yt_dlp/extractor/bilibili.py Outdated Show resolved Hide resolved
yt_dlp/extractor/bilibili.py Outdated Show resolved Hide resolved
yt_dlp/extractor/bilibili.py Outdated Show resolved Hide resolved
yt_dlp/extractor/bilibili.py Outdated Show resolved Hide resolved
@pukkandan pukkandan added site-enhancement Feature request for some website pending-fixes PR has had changes requested labels Feb 12, 2023
commit 6bc9f84
Author: HobbyistDev <tesutonihon4@gmail.com>
Date:   Tue Jan 24 20:09:53 2023 +0900

    add comment extraction support for user-generated content

commit 419f01f
Author: HobbyistDev <tesutonihon4@gmail.com>
Date:   Tue Jan 24 19:27:58 2023 +0900

    add comment about `type` query

commit 551d5bb
Author: HobbyistDev <tesutonihon4@gmail.com>
Date:   Mon Jan 23 23:18:18 2023 +0900

    remove comment

commit 3a2b135
Author: HobbyistDev <tesutonihon4@gmail.com>
Date:   Mon Jan 23 23:17:48 2023 +0900

    add timestamp metadata to comment

commit 9aae5be
Author: HobbyistDev <tesutonihon4@gmail.com>
Date:   Mon Jan 23 22:47:18 2023 +0900

    add comment reply extraction

commit d7f3c70
Author: HobbyistDev <tesutonihon4@gmail.com>
Date:   Mon Jan 23 19:39:57 2023 +0900

    [extractor/biliIntl] Add comment extraction from api
@HobbyistDev HobbyistDev reopened this Feb 14, 2023
HobbyistDev and others added 7 commits February 14, 2023 21:40
Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
@pukkandan pukkandan removed the pending-fixes PR has had changes requested label Mar 6, 2023
@pukkandan pukkandan merged commit b093c38 into yt-dlp:master Apr 12, 2023
@HobbyistDev HobbyistDev deleted the biliIntl-comment branch May 19, 2023 03:30
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-enhancement Feature request for some website
Projects
Status: bilibili
Development

Successfully merging this pull request may close these issues.

None yet

2 participants