Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[extractor/youtube] Fix parsing comment_count with unit suffix #6523

Merged
merged 2 commits into from Mar 14, 2023
Merged

[extractor/youtube] Fix parsing comment_count with unit suffix #6523

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
545b4c6
[extractor/youtube] Fix parsing `comment_count` with unit suffix
nick-cd Mar 12, 2023
a7b66d3
Fix: Edit `traverse_obj()`'s default parameter
nick-cd Mar 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions yt_dlp/extractor/youtube.py
View file
Open in desktop
Expand Up @@ -4265,11 +4265,11 @@ def process_language(container, base_url, lang_code, sub_name, query):

info['comment_count'] = traverse_obj(initial_data, (
'contents', 'twoColumnWatchNextResults', 'results', 'results', 'contents', ..., 'itemSectionRenderer',
'contents', ..., 'commentsEntryPointHeaderRenderer', 'commentCount', 'simpleText'
'contents', ..., 'commentsEntryPointHeaderRenderer', 'commentCount'
), (
'engagementPanels', lambda _, v: v['engagementPanelSectionListRenderer']['panelIdentifier'] == 'comment-item-section',
'engagementPanelSectionListRenderer', 'header', 'engagementPanelTitleHeaderRenderer', 'contextualInfo', 'runs', ..., 'text'
), expected_type=int_or_none, get_all=False)
'engagementPanelSectionListRenderer', 'header', 'engagementPanelTitleHeaderRenderer', 'contextualInfo'
), expected_type=self._get_count, get_all=False)

try: # This will error if there is no livechat
initial_data['contents']['twoColumnWatchNextResults']['conversationBar']['liveChatRenderer']['continuations'][0]['reloadContinuationData']['continuation']
Expand Down