Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extractor/dlf] Add support for Deutschlandfunk #6697

Merged
merged 10 commits into from May 2, 2023

Conversation

nick-cd
Copy link
Contributor

@nick-cd nick-cd commented Apr 2, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Deutschlandfunk is a radio broadcasting corporation based in Germany. They cover a wide variety of contemporary news topics.

Currently, this extractor exclusively supports pre-recorded broadcasts. DLF distributes its pre-recorded audio sources in one of the mp3 or m3u8 formats. The tests check for both of these cases. I do not have a single-recording test case for m3u8 sources.

As suggested in #6430, this extractor retrieves all the metadata from the <button> tag's HTML attributes.

Fixes #6430

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

This extractor probes the details page of a particular recording
and retrieves its metadata.
Some pages featuring a pre-recorded broadcast may have other recordings.
YT-DLP will recognize such pages as a playlist.
yt_dlp/extractor/dlf.py Outdated Show resolved Hide resolved
yt_dlp/extractor/dlf.py Outdated Show resolved Hide resolved
yt_dlp/extractor/dlf.py Show resolved Hide resolved
yt_dlp/extractor/dlf.py Outdated Show resolved Hide resolved
yt_dlp/extractor/dlf.py Outdated Show resolved Hide resolved
yt_dlp/extractor/dlf.py Outdated Show resolved Hide resolved
yt_dlp/extractor/dlf.py Outdated Show resolved Hide resolved
yt_dlp/extractor/dlf.py Outdated Show resolved Hide resolved
yt_dlp/extractor/dlf.py Outdated Show resolved Hide resolved
yt_dlp/extractor/dlf.py Outdated Show resolved Hide resolved
@bashonly bashonly added site-request Request to support a new website pending-fixes PR has had changes requested labels Apr 29, 2023
The former link, https://www.deutschlandfunk.de/corso-100.html,
now contains several broken links, rendering it impractical for testing.
Copy link
Member

@bashonly bashonly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix the URL pattern overlap

yt_dlp/extractor/dlf.py Outdated Show resolved Hide resolved
yt_dlp/extractor/dlf.py Outdated Show resolved Hide resolved
@bashonly bashonly removed the pending-fixes PR has had changes requested label Apr 30, 2023
yt_dlp/extractor/dlf.py Outdated Show resolved Hide resolved
yt_dlp/extractor/dlf.py Outdated Show resolved Hide resolved
@bashonly bashonly requested a review from pukkandan April 30, 2023 23:56
yt_dlp/extractor/dlf.py Outdated Show resolved Hide resolved
yt_dlp/extractor/dlf.py Outdated Show resolved Hide resolved
@bashonly bashonly merged commit b423b6a into yt-dlp:master May 2, 2023
11 checks passed
dirkf added a commit to dirkf/youtube-dl that referenced this pull request May 3, 2023
dirkf added a commit to dirkf/youtube-dl that referenced this pull request May 3, 2023
dirkf added a commit to dirkf/youtube-dl that referenced this pull request Jul 18, 2023
dirkf added a commit to dirkf/youtube-dl that referenced this pull request Jul 19, 2023
dirkf added a commit to dirkf/youtube-dl that referenced this pull request Jul 19, 2023
dirkf added a commit to ytdl-org/youtube-dl that referenced this pull request Jul 19, 2023
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-request Request to support a new website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support requst for DLF
3 participants