New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extractor/dlf] Add support for Deutschlandfunk #6697
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extractor probes the details page of a particular recording and retrieves its metadata.
Some pages featuring a pre-recorded broadcast may have other recordings. YT-DLP will recognize such pages as a playlist.
The webpage, https://www.deutschlandfunk.de/tanz-der-saiteninstrumente-das-wild-strings-trio-aus-slowenien-dlf-03a3eb19-100.html now returns a 404 error.
bashonly
requested changes
Apr 29, 2023
bashonly
added
site-request
Request to support a new website
pending-fixes
PR has had changes requested
labels
Apr 29, 2023
The former link, https://www.deutschlandfunk.de/corso-100.html, now contains several broken links, rendering it impractical for testing.
bashonly
reviewed
Apr 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To fix the URL pattern overlap
bashonly
approved these changes
Apr 30, 2023
pukkandan
approved these changes
May 1, 2023
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
May 3, 2023
* from yt-dlp/yt-dlp#6697, thanks nick-cd
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
May 3, 2023
* from yt-dlp/yt-dlp#6697, thanks nick-cd
11 tasks
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
Jul 18, 2023
* from yt-dlp/yt-dlp#6697, thanks nick-cd
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
Jul 19, 2023
* from yt-dlp/yt-dlp#6697, thanks nick-cd
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
Jul 19, 2023
* from yt-dlp/yt-dlp#6697, thanks nick-cd
dirkf
added a commit
to ytdl-org/youtube-dl
that referenced
this pull request
Jul 19, 2023
* from yt-dlp/yt-dlp#6697, thanks nick-cd
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Closes yt-dlp#6430 Authored by: nick-cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Deutschlandfunk is a radio broadcasting corporation based in Germany. They cover a wide variety of contemporary news topics.
Currently, this extractor exclusively supports pre-recorded broadcasts. DLF distributes its pre-recorded audio sources in one of the
mp3
orm3u8
formats.The tests check for both of these cases.I do not have a single-recording test case form3u8
sources.As suggested in #6430, this extractor retrieves all the metadata from the
<button>
tag's HTML attributes.Fixes #6430
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?