Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "There are no" text in log output when attempting to download YouTube subtitles or thumbnails for a video without them #6728

Closed
wants to merge 2 commits into from
Closed

Conversation

synthead
Copy link

@synthead synthead commented Apr 6, 2023

Simple grammar fix in log output for YouTube when no subtitles exist for requested languages, and when attempting to download thumbnails when thumbnails aren't present.

Before:

[info] There's no subtitles for the requested languages

After:

[info] There are no subtitles for the requested languages

"There's" is a contraction for "there is," and "there is no subtitles" is not correct, as "is" is singular.

Fixes #6726

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@pukkandan pukkandan added the docs/meta/cleanup related to docs, code cleanup, templates, devscripts etc label Apr 7, 2023
@pukkandan pukkandan self-assigned this Apr 7, 2023
@pukkandan
Copy link
Member

Same for thumbnails

@synthead
Copy link
Author

synthead commented Apr 7, 2023

Same for thumbnails

@pukkandan, are you suggesting to also fix possible grammar issues for thumbnails as a part of this PR?

@pukkandan
Copy link
Member

Yes. The same sentence is used for thumbnails and description. For description, it makes sense since there is only one. Since you are fixing subs, fix thumbs too.

@synthead synthead changed the title Use "There are no subtitles" text in log output when attempting to download YouTube subtitles for a video without subtitles Use "There are no" text in log output when attempting to download YouTube subtitles or thumbnails for a video without them Apr 15, 2023
@synthead
Copy link
Author

@pukkandan, I included a grammar fix for thumbnails and updated this PR's title and body to reflect the changes 👍

@synthead
Copy link
Author

synthead commented May 2, 2023

Hi @pukkandan! Are there any other changes you'd like me to add to this PR? Thanks!

@pukkandan pukkandan closed this in c8bc203 May 19, 2023
stanoarn pushed a commit to stanoarn/yt-dlp that referenced this pull request May 26, 2023
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs/meta/cleanup related to docs, code cleanup, templates, devscripts etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect grammar in YouTube log output: "There's no subtitles" should be "There are no subtitles"
2 participants