[ie/triller] Fix unlisted video extraction #7670
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triller's brilliant API started returning a string (not boolean) value of
"true"
/"false"
in thefollowed_by_me
field, which made the error handling for private profiles useless.This PR also removes the
private
check from video extraction, since apparently "private" actually means "unlisted", and private videos can be watched/downloaded as long as the video URL is known.Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
🤖 Generated by Copilot at 3d55bfe
Summary
🔀🛡️🧰
Refactored the Triller extractor to handle privacy and block checks in the specific subclasses. Simplified the user info extraction with
traverse_obj
.Walkthrough
_check_user_info
method fromTrillerBaseIE
class, as it is no longer used by subclasses (link)_real_extract
method ofTrillerIE
class, using API response fields directly (link)_real_extract
method ofTrillerUserIE
class, usingtraverse_obj
utility function and converting string values to booleans (link)