Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extractor/rbgtum] fix m3u8 regex, add new hostname #7690

Merged
merged 13 commits into from Sep 21, 2023

Conversation

simon300000
Copy link
Contributor

@simon300000 simon300000 commented Jul 25, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

This pr contains:

  1. adjust some regex to capture the jwt after m3u8 url
  2. add support for new hostname tum.live
Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

🤖 Generated by Copilot at 05a2890

Summary

🆕🛠️🧹

Improved and fixed RbgTumIE and RbgTumCourseIE extractors to handle new domain and URL formats. Added tests and refactored code for clarity and robustness.

Oh we are the coders of the tum.live domain
We extract the videos with skill and with brain
We fix the URLs and we test every case
We heave away and haul away and keep up with the pace

Walkthrough

  • Update the RbgTumIE and RbgTumCourseIE extractors to support the new domain tum.live as an alternative to live.rbg.tum.de (link, link)
  • Fix the extraction of some videos that have a query string in their m3u8 URL by including the optional query string in the _html_search_regex call for the m3u8 variable in the RbgTumIE extractor (link)
  • Use the hostname variable from the _match_valid_url call instead of hardcoding the live.rbg.tum.de domain in the RbgTumCourseIE extractor, to make it more flexible and consistent with the RbgTumIE extractor (link, link)
  • Add test cases to the RbgTumIE and RbgTumCourseIE extractors to check the extraction of videos and courses from the new domain tum.live (link, link)
1. 213

Copy link
Member

@pukkandan pukkandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see a few issues in the IE unrelated to your PR. I'll refrain from suggesting changes for them unless you are interested in looking at them.

yt_dlp/extractor/rbgtum.py Outdated Show resolved Hide resolved
yt_dlp/extractor/rbgtum.py Outdated Show resolved Hide resolved
yt_dlp/extractor/rbgtum.py Outdated Show resolved Hide resolved
yt_dlp/extractor/rbgtum.py Outdated Show resolved Hide resolved
yt_dlp/extractor/rbgtum.py Outdated Show resolved Hide resolved
@pukkandan pukkandan added the site-bug Issue with a specific website label Jul 26, 2023
@simon300000
Copy link
Contributor Author

I can see a few issues in the IE unrelated to your PR. I'll refrain from suggesting changes for them unless you are interested in looking at them.

I am happy to take a look

yt_dlp/extractor/rbgtum.py Outdated Show resolved Hide resolved
yt_dlp/extractor/rbgtum.py Outdated Show resolved Hide resolved
yt_dlp/extractor/rbgtum.py Outdated Show resolved Hide resolved
yt_dlp/extractor/rbgtum.py Outdated Show resolved Hide resolved
yt_dlp/extractor/rbgtum.py Outdated Show resolved Hide resolved
Co-authored-by: pukkandan <pukkandan.ytdlp@gmail.com>
@simon300000
Copy link
Contributor Author

Ok, it seems like there was a big change to the website layout yesterday, I have to adopt it now.

how coincident :D

@simon300000
Copy link
Contributor Author

The new ui should be working, a new json extractor added, with the old html parser as backup

@bashonly bashonly self-requested a review September 17, 2023 13:32
yt_dlp/extractor/rbgtum.py Outdated Show resolved Hide resolved
yt_dlp/extractor/rbgtum.py Outdated Show resolved Hide resolved
yt_dlp/extractor/rbgtum.py Outdated Show resolved Hide resolved
yt_dlp/extractor/rbgtum.py Outdated Show resolved Hide resolved
yt_dlp/extractor/rbgtum.py Outdated Show resolved Hide resolved
yt_dlp/extractor/rbgtum.py Outdated Show resolved Hide resolved
yt_dlp/extractor/rbgtum.py Outdated Show resolved Hide resolved
yt_dlp/extractor/rbgtum.py Outdated Show resolved Hide resolved
yt_dlp/extractor/rbgtum.py Outdated Show resolved Hide resolved
yt_dlp/extractor/rbgtum.py Outdated Show resolved Hide resolved
@bashonly bashonly added the pending-fixes PR has had changes requested label Sep 19, 2023
simon300000 and others added 4 commits September 19, 2023 18:49
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
yt_dlp/extractor/rbgtum.py Outdated Show resolved Hide resolved
yt_dlp/extractor/rbgtum.py Outdated Show resolved Hide resolved
yt_dlp/extractor/rbgtum.py Outdated Show resolved Hide resolved
@bashonly bashonly added pending-review PR needs a review and removed pending-fixes PR has had changes requested labels Sep 19, 2023
@bashonly bashonly removed the pending-review PR needs a review label Sep 21, 2023
@bashonly bashonly merged commit 5fccaba into yt-dlp:master Sep 21, 2023
16 checks passed
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants