Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

update FOX regex to include Fox Sports replays #7724

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

ischmidt20
Copy link
Contributor

@ischmidt20 ischmidt20 commented Jul 29, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Fox has recently moved sports replays away from fox.com/watch and to foxsports.com/replays. This change updates the extractor to match these new URLs. Nothing in the extractor internals changes.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

馃 Generated by Copilot at 535a086

Summary

馃馃摵馃敡

Improve FOX extractor by expanding URL pattern and supporting more video types. Update yt_dlp/extractor/fox.py accordingly.

_VALID_URL grows
To catch more foxes in watch
Autumn of content

Walkthrough

  • Update the URL pattern to support more FOX videos (link)

@bashonly bashonly added the site-bug Issue with a specific website label Jul 29, 2023
@pukkandan
Copy link
Member

Pls add a test (only_matching is fine)

@ischmidt20
Copy link
Contributor Author

ischmidt20 commented Aug 1, 2023

Test added @pukkandan

@pukkandan pukkandan merged commit 30b29f3 into yt-dlp:master Aug 1, 2023
13 checks passed
@ischmidt20 ischmidt20 deleted the fox branch April 14, 2024 01:26
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants