Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extractor/s4c]: Add extractor #7730

Merged
merged 4 commits into from
Aug 1, 2023
Merged

[extractor/s4c]: Add extractor #7730

merged 4 commits into from
Aug 1, 2023

Conversation

ifan-t
Copy link
Contributor

@ifan-t ifan-t commented Jul 30, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

This extractor adds support for videos on https://www.s4c.cymru/clic which hosts videos from the Welsh language S4C TV channel.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

🤖 Generated by Copilot at 076d8fd

Summary

✨📺🐉

Add support for downloading videos from S4C, a Welsh language broadcaster. Create a new s4c.py module that defines the S4CIE extractor class and import it in _extractors.py.

S4CIE extracts
videos from Welsh website
autumn leaves fall fast

Walkthrough

  • Add support for S4C video extraction (link, link)
    • Import S4CIE class from s4c.py module in _extractors.py (link)
    • Define S4CIE class in s4c.py module that inherits from InfoExtractor (link)

yt_dlp/extractor/_extractors.py Outdated Show resolved Hide resolved
yt_dlp/extractor/s4c.py Outdated Show resolved Hide resolved
yt_dlp/extractor/s4c.py Outdated Show resolved Hide resolved
yt_dlp/extractor/s4c.py Outdated Show resolved Hide resolved
yt_dlp/extractor/s4c.py Outdated Show resolved Hide resolved
yt_dlp/extractor/s4c.py Outdated Show resolved Hide resolved
yt_dlp/extractor/s4c.py Outdated Show resolved Hide resolved
yt_dlp/extractor/s4c.py Outdated Show resolved Hide resolved
@bashonly bashonly added site-request Request to support a new website pending-fixes PR has had changes requested labels Jul 30, 2023
yt_dlp/extractor/s4c.py Outdated Show resolved Hide resolved
yt_dlp/extractor/s4c.py Outdated Show resolved Hide resolved
yt_dlp/extractor/s4c.py Outdated Show resolved Hide resolved
yt_dlp/extractor/s4c.py Outdated Show resolved Hide resolved
@bashonly bashonly added pending-review PR needs a review and removed pending-fixes PR has had changes requested labels Jul 31, 2023
@bashonly bashonly removed the pending-review PR needs a review label Jul 31, 2023
@bashonly bashonly merged commit b9de629 into yt-dlp:master Aug 1, 2023
13 checks passed
dirkf added a commit to dirkf/youtube-dl that referenced this pull request Aug 4, 2023
dirkf added a commit to ytdl-org/ytdl-nightly that referenced this pull request Sep 4, 2023
dirkf added a commit to ytdl-org/ytdl-nightly that referenced this pull request Sep 5, 2023
dirkf added a commit to ytdl-org/ytdl-nightly that referenced this pull request Sep 24, 2023
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-request Request to support a new website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants