-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extractor/s4c]: Add extractor #7730
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashonly
requested changes
Jul 30, 2023
bashonly
approved these changes
Jul 31, 2023
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
Aug 4, 2023
* from yt-dlp/yt-dlp#7730, thx ifan-t, bashonly
dirkf
added a commit
to ytdl-org/ytdl-nightly
that referenced
this pull request
Sep 4, 2023
* from yt-dlp/yt-dlp#7730, thx ifan-t, bashonly
dirkf
added a commit
to ytdl-org/ytdl-nightly
that referenced
this pull request
Sep 5, 2023
* from yt-dlp/yt-dlp#7730, thx ifan-t, bashonly
dirkf
added a commit
to ytdl-org/ytdl-nightly
that referenced
this pull request
Sep 24, 2023
* from yt-dlp/yt-dlp#7730, thx ifan-t, bashonly
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Authored by: ifan-t
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
This extractor adds support for videos on https://www.s4c.cymru/clic which hosts videos from the Welsh language S4C TV channel.
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
🤖 Generated by Copilot at 076d8fd
Summary
✨📺🐉
Add support for downloading videos from S4C, a Welsh language broadcaster. Create a new
s4c.py
module that defines theS4CIE
extractor class and import it in_extractors.py
.Walkthrough
S4CIE
class froms4c.py
module in_extractors.py
(link)S4CIE
class ins4c.py
module that inherits fromInfoExtractor
(link)