Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[extractor/substack] Return canonical URLs #8219

Merged
merged 2 commits into from Oct 6, 2023
Merged

[extractor/substack] Return canonical URLs #8219

merged 2 commits into from Oct 6, 2023

Commits on Sep 27, 2023

  1. [extractor/substack] Return canonical URLs 

    The URL passed to _real_extract is of format "{username}.substack.com",
but for blogs with custom domains the canonical URL would use the custom
domain. Because of the wrong URL, the cookies in the resulting info dict
come from the wrong domain, which breaks subscriber content extraction.
    @handlerug
    handlerug committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    fa51465 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. Apply suggestions from code review 

    Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
    @handlerug @bashonly
    handlerug and bashonly committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    c7eb0f9 View commit details
    Browse the repository at this point in the history