Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/youtube] Check newly uploaded iOS HLS formats #8336

Merged
merged 2 commits into from Oct 28, 2023

Conversation

bashonly
Copy link
Member

@bashonly bashonly commented Oct 12, 2023

Force --check-formats for newly uploaded iOS HLS formats. Adds private __needs_testing format field.

Closes #7747

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

馃 Generated by Copilot at 3f66ed9

Summary

馃啎馃搯馃摵

Add a flag to mark and test potentially problematic HLS formats for newly uploaded YouTube videos. Modify yt_dlp/extractor/youtube.py and yt_dlp/YoutubeDL.py to implement this feature.

YoutubeIE checks
HLS formats for new videos
Winter of glitches

Walkthrough

  • Add a flag to mark potentially problematic HLS formats for newly uploaded YouTube videos (link)
  • Test and filter out formats that have the flag set in the _check_formats function (link)

@bashonly bashonly added the site-bug Issue with a specific website label Oct 12, 2023
Copy link
Member

@Grub4K Grub4K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a huge fan of datetime_from_str but its a lot more readable tbh

@bashonly bashonly self-assigned this Oct 22, 2023
@bashonly bashonly merged commit ef79d20 into yt-dlp:master Oct 28, 2023
16 checks passed
@bashonly bashonly deleted the fix/youtube-ios-check branch December 7, 2023 15:10
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some Youtube m3u8 formats fail to download with a 404
3 participants