Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error parsing the episode list of series for ABC AU #8572

Closed
wants to merge 1 commit into from

Conversation

rifuller
Copy link

@rifuller rifuller commented Nov 12, 2023

IMPORTANT: PRs without the template will be CLOSED

Fix error parsing the episode list of series for ABC AU

ADD DESCRIPTION HERE

Fixes #

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

馃 Generated by Copilot at ecc4328

Summary

馃悰馃摵馃啓

Fix playlist extraction for ABC iView show series. Update yt_dlp/extractor/abc.py to handle the new API format with nested items key.

videoEpisodes
Nested items hold the key
Bug fix for iView

Walkthrough

  • Fix playlist extraction from ABC iView show series API response (link)

@bashonly
Copy link
Member

Feel free to use this patch:

since we want the extractor to work with both JSON structures.

And please add a test for a URL where the newly-supported structure is used

@bashonly bashonly added the site-bug Issue with a specific website label Nov 13, 2023
@rifuller
Copy link
Author

rifuller commented Nov 14, 2023

If #8554 supersedes this, then this PR can be closed. Unfortunately, I can't work on this more at the moment because I'm overseas.

@bashonly bashonly added the incomplete Further information is needed label Nov 14, 2023
@bashonly bashonly closed this in 15cb352 Nov 15, 2023
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incomplete Further information is needed site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants