[build] Make secretstorage an optional dependency
#8585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Authored by: bashonly
Authored by: bashonly
bashonly
added
the
docs/meta/cleanup
coletdjnz
approved these changes
Nov 15, 2023
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Nov 19, 2023
py-SecretStorage pulls a lot of dependencies for a small optional feature in yt-dlp. The upstream merged the PR that also makes SecretStorage optional: yt-dlp/yt-dlp#8585 PR: 275196 Submitted by: Helge Oldach <freebsd@oldach.net> (initial version)
netgate-git-updates
pushed a commit
to pfsense/FreeBSD-ports
that referenced
this pull request
Nov 27, 2023
py-SecretStorage pulls a lot of dependencies for a small optional feature in yt-dlp. The upstream merged the PR that also makes SecretStorage optional: yt-dlp/yt-dlp#8585 PR: 275196 Submitted by: Helge Oldach <freebsd@oldach.net> (initial version)
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Authored by: bashonly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pip is failing to install yt-dlp 2023.11.14 on linux systems with CPython 3.11+ that do not have Rust installed, since PyPI does not provide pre-built py3.11+ wheels for
cryptography(a dependency ofsecretstorage).This partially reverts 9970d74, but we can continue to include
secretstoragein the Linux builds, and aim to add it properly as an optional dependency after #8550 is complete.Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?