Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/nintendo] Fix Nintendo Direct extraction #8609

Merged
merged 8 commits into from Nov 18, 2023

Conversation

Grub4K
Copy link
Member

@Grub4K Grub4K commented Nov 18, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

This rewrite redirects Nintendo Direct extraction to the GraphQL-API endpoint.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

yt_dlp/extractor/nintendo.py Outdated Show resolved Hide resolved
yt_dlp/extractor/nintendo.py Show resolved Hide resolved
yt_dlp/extractor/nintendo.py Show resolved Hide resolved
yt_dlp/extractor/nintendo.py Outdated Show resolved Hide resolved
yt_dlp/extractor/nintendo.py Outdated Show resolved Hide resolved
yt_dlp/extractor/nintendo.py Show resolved Hide resolved
yt_dlp/extractor/nintendo.py Show resolved Hide resolved
yt_dlp/extractor/nintendo.py Outdated Show resolved Hide resolved
@bashonly bashonly added the site-bug Issue with a specific website label Nov 18, 2023
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
@seproDev
Copy link
Collaborator

The local parsing logic doesn't seem quite right.
In my browser, I get redirected to this link: https://www.nintendo.com/us/nintendo-direct/09-14-2023/ which then extracts us_US as the parsed_locale, which fails to download.

There are also some directs which are hosted on YouTube https://www.nintendo.com/us/nintendo-direct/50-fact-extravaganza/

@Grub4K Grub4K requested a review from seproDev November 18, 2023 18:49
@Grub4K Grub4K merged commit 1d24da6 into yt-dlp:master Nov 18, 2023
15 checks passed
@Grub4K Grub4K deleted the fix/nintendo-direct branch November 18, 2023 20:04
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants