-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ARD Mediathek URLs with "serien" (fixes #7666) #8687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lstrojny
changed the title
Support for URLs with serien (fixes #7666)
Support ARD Mediathek URLs with "serien" (fixes #7666)
Nov 30, 2023
Grub4K
approved these changes
Nov 30, 2023
Co-authored-by: Simon Sawicki <accounts@grub4k.xyz>
Sadly, can't get this PR to work for the series landing page of Parlament Staffel 1 nor an individual video from there. (after setting up virtualenv) gh repo clone https://github.com/yt-dlp/yt-dlp
cd yt-dlp
gh pr checkout 8687
pip install .
~/src/yt-dlp/yt-dlp.sh -v https://www.ardmediathek.de/serie/parlament/staffel-1/Y3JpZDovL3dkci5kZS9vbmUvcGFybGFtZW50bmV1/1 yields
|
@marcusmueller it's a different general issue. See #8731. |
seproDev
approved these changes
Dec 23, 2023
bashonly
approved these changes
Dec 24, 2023
aalsuwaidi
pushed a commit
to aalsuwaidi/yt-dlp
that referenced
this pull request
Apr 21, 2024
Closes yt-dlp#7666 Authored by: lstrojny
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Adds support for the following URL scheme:
https://www.ardmediathek.de/serie/…
, e.g. https://www.ardmediathek.de/serie/nachtstreife/staffel-1/Y3JpZDovL3N3ci5kZS9zZGIvc3RJZC8xMjQy/1Fixes #7666
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?